Skip to content

Ensure json rules cannot run python code while being parsed #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2025
Merged

Ensure json rules cannot run python code while being parsed #149

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/Helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import ast
import csv
import os
import pkgutil
Expand Down Expand Up @@ -271,7 +272,14 @@ def checktype(target_type, found_types: list):
elif issubclass(value_type, list) or issubclass(value_type, dict) \
or issubclass(value_type, set) or issubclass(type(value_type), GenericAlias):
try:
converted_value = eval(value)
try:
converted_value = ast.literal_eval(value)
except ValueError as e:
# The ValueError from ast when the string cannot be evaluated as a literal is usually something like
# "malformed node or string on line 1: <ast.Name object at 0x000001AEBBCC7590>", which is not
# helpful, so re-raise with a better exception message.
raise ValueError(f"'{value}' could not be evaluated as a literal") from e

compareto = get_origin(value_type) if issubclass(type(value_type), GenericAlias) else value_type
if issubclass(compareto, type(converted_value)):
return converted_value
Expand Down