Ensure json rules cannot run python code while being parsed #149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hooks and modifications to the manual world itself are expected places that could run any python code. What is not expected is json rules themselves running python code while being parsed. Due to the use of `eval()`, function arguments within json rules could have run arbitrary code while being parsed. The use of `eval` has been replaced with `ast.literal_eval`, ensuring that function arguments being parsed in json rules cannot run arbitrary Python code.
silasary
approved these changes
May 6, 2025
|
Good catch :) |
FuzzyGamesOn
approved these changes
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hooks and modifications to the manual world itself are expected places that could run any python code. What is not expected is json rules themselves running python code when being parsed.
Due to the use of
eval(), function arguments within json rules could have run arbitrary code.The use of
evalhas been replaced withast.literal_eval, ensuring that function arguments being parsed in json rules cannot run arbitrary Python code.Json rules should be considered 'safe', not requiring any sort of review, in my opinion. Without this change, json rules are currently 'unsafe' and would have to be reviewed alongside any hooks a custom manual world adds, or any changes a custom manual world makes to the base manual world.
As a note, the code that is using
evalis not present in any stable or unstable releases of Manual yet.