Skip to content

Fixed -a flag for OpenGL rendering #2011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 9, 2021

Conversation

k4pran
Copy link
Collaborator

@k4pran k4pran commented Sep 4, 2021

Overview: What does this pull request change?

Motivation and Explanation: Why and how do your changes improve the library?

Fixes #2009

When using the -a flag the opengl renderer was not outputting all scenes, this fixes it, but only made applicable to non-interactive mode.

Links to added or changed documentation pages

Further Information and Comments

Only tests for this exist for cairo, opengl tests will be added in #2008

Reviewer Checklist

  • The PR title is descriptive enough for the changelog, and the PR is labeled correctly
  • If applicable: newly added non-private functions and classes have a docstring including a short summary and a PARAMETERS section
  • If applicable: newly added functions and classes are tested

@k4pran k4pran added pr:bugfix Bug fix for use in PRs solving a specific issue:bug opengl Concerning the OpenGL renderer. labels Sep 4, 2021
Copy link
Member

@hydrobeam hydrobeam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested out the changes and it does work 👍, so LGTM. I'm curious as to what these changes do and why it didn't work before, yet worked with cairo?

@k4pran
Copy link
Collaborator Author

k4pran commented Sep 4, 2021

Tested out the changes and it does work 👍, so LGTM. I'm curious as to what these changes do and why it didn't work before, yet worked with cairo?

The opengl scene selection has different logic to accommodate interactive mode, scene rerun etc so it is a bit more complex, there was an issue where opengl only ever rendered the first scene and ignored user selection, that was fixed but I guess the issue with -a was still broken. These changes basically just use similar logic to the Cairo one and ignore the rerun scene logic

@k4pran k4pran mentioned this pull request Sep 4, 2021
3 tasks
@hydrobeam hydrobeam merged commit 8c9ae5b into ManimCommunity:main Sep 9, 2021
@hydrobeam hydrobeam changed the title Fixed -a flag for opengl Fixed -a flag for OpenGL. Sep 9, 2021
@behackl behackl changed the title Fixed -a flag for OpenGL. Fixed -a flag for OpenGL rendering Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
opengl Concerning the OpenGL renderer. pr:bugfix Bug fix for use in PRs solving a specific issue:bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Opengl -a flag not working with opengl
4 participants