Skip to content

Reuse CLI flag tests for OpenGL #2008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 29, 2021

Conversation

k4pran
Copy link
Collaborator

@k4pran k4pran commented Sep 4, 2021

Overview: What does this pull request change?

Motivation and Explanation: Why and how do your changes improve the library?

To help give us confidence during transition to opengl we can duplicate cairo CLI tests to improve our opengl test coverage and ensure current behaviour is consistent during transition

Links to added or changed documentation pages

Further Information and Comments

Below are the currently failing tests

Test Name Comments
test_mp4_format_output dependent on #1982
test_gif_format_output dependent on #1982
test_a_flag dependent on #2011
test_images_are_created_when_png_format_set dependent on #1982
test_images_are_zero_padded_when_zero_pad_set dependent on #1982
test_webm_format_output dependent on #1982
test_default_format_output_for_transparent_flag dependent on #1982
test_mov_can_be_set_as_output_format dependent on #1982

Reviewer Checklist

  • The PR title is descriptive enough for the changelog, and the PR is labeled correctly
  • If applicable: newly added non-private functions and classes have a docstring including a short summary and a PARAMETERS section
  • If applicable: newly added functions and classes are tested

@k4pran k4pran mentioned this pull request Sep 4, 2021
3 tasks
@k4pran k4pran added opengl Concerning the OpenGL renderer. testing Anything related to testing the library labels Sep 4, 2021
@k4pran k4pran marked this pull request as ready for review September 28, 2021 18:25
@k4pran k4pran changed the title Duplicate CLI flag tests for opengl Reuse CLI flag tests for opengl Sep 28, 2021
@k4pran k4pran force-pushed the add_opengl_cli_tests branch from 64610a5 to b6e1e10 Compare September 28, 2021 18:28
Copy link
Member

@Darylgolden Darylgolden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Darylgolden Darylgolden enabled auto-merge (squash) September 29, 2021 11:11
@Darylgolden Darylgolden merged commit 0f027fc into ManimCommunity:main Sep 29, 2021
@behackl behackl changed the title Reuse CLI flag tests for opengl Reuse CLI flag tests for OpenGL Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
opengl Concerning the OpenGL renderer. testing Anything related to testing the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants