Skip to content

Simplified folder Structure #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Simplified folder Structure #132

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d4b6228
#Simplified folder Structure
kolibril13 Jun 3, 2020
ccdffc6
Update scene_file_writer.py
kolibril13 Jun 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 6 additions & 14 deletions manim/scene/scene_file_writer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,26 +68,18 @@ def init_output_directories(self):
"""
module_directory = self.output_directory or self.get_default_module_directory()
scene_name = self.file_name or self.get_default_scene_name()
#print("1")
#print(dirs.MEDIA_DIR)
if self.save_last_frame or self.save_pngs:
if dirs.MEDIA_DIR != "":
image_dir = guarantee_existence(os.path.join(
dirs.MEDIA_DIR,
"images",
module_directory,
))
image_dir = guarantee_existence(os.path.join(
dirs.VIDEO_DIR
))
self.image_file_path = os.path.join(
image_dir,
add_extension_if_not_present(scene_name, ".png")
)
if self.write_to_movie:
if dirs.VIDEO_DIR != "":
movie_dir = guarantee_existence(os.path.join(
dirs.VIDEO_DIR,
module_directory,
self.get_resolution_directory(),
))
movie_dir = guarantee_existence(os.path.join(
dirs.VIDEO_DIR
))
Comment on lines +80 to +82
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is my understanding from #66 that we are still going to have subdirectories for different resolutions. CC @eulertour

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion subdirectories for different resolutions are not that beneficial, because with them it is not anymore easy to switch between videos when working with the explorer.
Further, it is very easy to obtain the video result on very quickly: right-click on the file, and then on "show information", or you can get a feeling of the resolution when looking on the size the video file has. Also, any video-editing software is showing the clip resolution.
So I would definitely prefer the simpler version, where videos are easy to access.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't prefer being forced to run with the simple structure. Making it optional would be okay, forcing it on everyone, not so much.

self.movie_file_path = os.path.join(
movie_dir,
add_extension_if_not_present(
Expand Down