Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[F] Add markdown blocks to RG homepage #3807

Merged
merged 6 commits into from
Feb 7, 2025
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
[E] Auto assign title + hide field for markdown
  • Loading branch information
1aurend committed Feb 7, 2025
commit c63a03797950568aad78837626bf1a5db2eabc61
Original file line number Diff line number Diff line change
@@ -1,44 +1,53 @@
import React, { useState } from "react";
import PropTypes from "prop-types";
import { useTranslation } from "react-i18next";
import { useUID } from "react-uid";
import { useUID, useUIDSeed } from "react-uid";
import IconComposer from "global/components/utility/IconComposer";
import * as Styled from "./styles";

function CategoryCreator({ onSubmit, isMarkdown }) {
function CategoryCreator({ onSubmit, isMarkdown, count }) {
const { t } = useTranslation();

const uid = useUID();
const seed = useUIDSeed();

const [inputValue, setInputValue] = useState("");

function handleSubmit(event) {
event.preventDefault();
onSubmit({ title: inputValue, markdownOnly: isMarkdown });
const title = isMarkdown ? `markdown_${seed(count)}` : inputValue;
onSubmit({ title, markdownOnly: isMarkdown });
setInputValue("");
}

const label = isMarkdown
const buttonLabel = isMarkdown
? t("forms.category.add_markdown")
: t("forms.category.create");
: t("actions.add");
const placeholder = isMarkdown
? t("forms.category.title_placeholder")
: t("forms.category.name_placeholder");

const ButtonComponent = isMarkdown ? Styled.MarkdownButton : Styled.Button;

return (
<Styled.CategoryCreator onSubmit={handleSubmit}>
<Styled.Label htmlFor={uid}>{label}:</Styled.Label>
{!isMarkdown && (
<Styled.Label htmlFor={uid}>{t("forms.category.create")}</Styled.Label>
)}
<Styled.InputWrapper>
<Styled.Input
id={uid}
type="text"
value={inputValue}
onChange={({ target: { value } }) => setInputValue(value)}
placeholder={placeholder}
required
required={!isMarkdown}
hidden={isMarkdown}
/>
<Styled.Button type="submit">
<ButtonComponent type="submit">
<IconComposer icon="circlePlus32" size={32} />
<span>{t("actions.add")}</span>
</Styled.Button>
<span>{buttonLabel}</span>
</ButtonComponent>
</Styled.InputWrapper>
</Styled.CategoryCreator>
);
Expand All @@ -48,7 +57,9 @@ CategoryCreator.displayName =
"ReadingGroup.Collecting.CollectionEditor.CategoryCreator";

CategoryCreator.propTypes = {
onSubmit: PropTypes.func.isRequired
onSubmit: PropTypes.func.isRequired,
isMarkdown: PropTypes.bool,
count: PropTypes.number
};

export default CategoryCreator;
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ const inputHeight = collectableMinHeight;
export const CategoryCreator = styled.form`
--label-color: var(--color-base-neutral80);
--label-margin-bottom: 20px;

align-self: end;
`;

export const Label = styled.label`
Expand Down Expand Up @@ -70,3 +72,8 @@ export const Button = styled.button`
margin-inline-start: 0.75em;
}
`;

export const MarkdownButton = styled(Button)`
border-radius: var(--box-border-radius);
margin-inline-start: auto;
`;
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ function CategoryEdit({ category, groupId, onSuccess, onCancel }) {

const nameLabel = isMarkdown ? t("common.title") : t("forms.category.name");
const descriptionLabel = isMarkdown
? t("common.body")
? t("common.content")
: t("forms.category.description");
const descriptionPlaceholder = isMarkdown
? t("forms.category.markdown_body_placeholder")
Expand All @@ -34,12 +34,14 @@ function CategoryEdit({ category, groupId, onSuccess, onCancel }) {
className="form-secondary"
>
<Form.FieldGroup>
<Form.TextInput
wide
label={nameLabel}
name="attributes[title]"
placeholder={t("forms.category.name_placeholder")}
/>
{!isMarkdown && (
<Form.TextInput
wide
label={nameLabel}
name="attributes[title]"
placeholder={t("forms.category.name_placeholder")}
/>
)}
<Form.TextArea
wide
height={122}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,15 +17,17 @@ function CategoryHeader({
}) {
const { t } = useTranslation();

const { markdownOnly, title } = category?.attributes ?? {};

return (
<>
<Collapse initialVisible={initExpanded}>
<Styled.Header>
<Styled.Title>{category?.attributes.title}</Styled.Title>
{!markdownOnly && <Styled.Title>{title}</Styled.Title>}
{dragProps && (
<Styled.Actions>
<CategoryRemove
isMarkdown={!!category.attributes.markdownOnly}
isMarkdown={!!markdownOnly}
onRemove={() => onCategoryRemove(category)}
/>
<Styled.Action as={Collapse.Toggle}>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ export const Header = styled.header`
background-color: var(--box-medium-bg-color);
border-top-left-radius: var(--box-border-radius);
border-top-right-radius: var(--box-border-radius);
min-block-size: 52px;
`;

export const Title = styled.h3`
Expand All @@ -40,6 +41,10 @@ export const Actions = styled.div`
align-items: center;
margin-inline-start: 10px;
color: var(--color);

&:only-child {
margin-inline-start: auto;
}
`;

export const Action = styled.div`
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,11 @@ function CollectionEditor({
<Styled.Editor>
<Styled.CategoryInputs>
<CategoryCreator onSubmit={createCategory} />
<CategoryCreator onSubmit={createCategory} isMarkdown />
<CategoryCreator
onSubmit={createCategory}
count={categories?.length ?? 0}
isMarkdown
/>
</Styled.CategoryInputs>
<SortableCategories
collection={collection}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,5 +23,5 @@ export const CategoryInputs = styled.div`
row-gap: 25px;
grid-template-columns: 1fr;

${respond(`grid-template-columns: 1fr 1fr;`, 85)}
${respond(`grid-template-columns: 1fr auto;`, 85)}
`;
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ function Category({ category, mappings, responses, onUncollect }) {
return (
<CategoryComponent>
<Styled.Header>
<Styled.Title>{title}</Styled.Title>
{!markdownOnly && <Styled.Title>{title}</Styled.Title>}
{descriptionFormatted && (
<Styled.Description
dangerouslySetInnerHTML={{ __html: descriptionFormatted }}
Expand Down