-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[F] Add markdown blocks to RG homepage #3807
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, Lauren! Thanks for fixing those bugs too. I have two small suggested changes:
- Can the title be optional on the markdown block? Or include a flag to hide it? It seems like it shouldn't be required.
- The markdown block should be visually distinct from the categories. How about just making the background transparent and removing the block padding?
![Screenshot 2025-01-30 at 3 04 26 PM](https://private-user-images.githubusercontent.com/12454203/408335033-21fee356-c9e6-4917-a1c1-222e8fe6ed8f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzMDQ1NjUsIm5iZiI6MTczOTMwNDI2NSwicGF0aCI6Ii8xMjQ1NDIwMy80MDgzMzUwMzMtMjFmZWUzNTYtYzllNi00OTE3LWExYzEtMjIyZThmZTZlZDhmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjExVDIwMDQyNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWZlZDM3N2I2Y2FjYjc5M2Y2MjQ2NDBkZTYzNzQ4Yjg1M2I4OTQ0Y2YxYzY0NWM4YTNmZjk3OTkxY2MxMDRhNzcmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.z0nRx5DgEnhi8CogQTFfxt47LLKk4_TAjHoaHWGbwHc)
Oh yeah, that looks good. Re: optional title— it's currently a required property in the api. I can take a look at what side effects there might be of making it optional, and whether a flag would be easier. Perhaps another option could be to assign a title to the markdown blocks on creation, something like |
Yeah I like the generated title idea! Since it's a markdown block, they can just add headings if they need them. (And yes to add the RTE styles 👍🏻 ) |
@dananjohnson this should be ready to go. Do you want to give it another quick look and unblock merging (or just merge)? One thing for later— h1 is allowed in markdown in Manifold. Those should probably be converted to h2 by the system. If we wanted to do that, it would either be an api change in the html rendering, or we could add a React markdown renderer and stop using dangerouslySetInnerHTML here. |
Go ahead and merge it. Let's set the h1 question aside for now. I'm not sure it's worth implementing the constraints on our end since it's largely up to content editors to use proper heading structure. |
Also, fixes..