miq-site-switcher - move component from ui-components here #1615
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not used outside SUI, moving here
`yarn run test` runs too many things, adding `t` to just run the actual tests, and moving the karma invokation into a separate `test:karma` rule
|
Checked commits https://github.com/himdel/manageiq-ui-service/compare/04fea231b217d841d4ab15e6c07fd47194ae5b2a~...56e2703ced6378f83fe3197d3ae3fc70f3063495 with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
mzazrivec
approved these changes
Jan 17, 2020
29 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
site-switcher is not used outside SUI, moving here.
(removed from ui-components in ManageIQ/ui-components#433)