Move components from *ui-components #6716
Description
Current state:
- uses release branches (gaprindashvili, hammer, ivanchuk, master), corresponding to 0.9 (bower), 1.0, 1.1 and 1.2 npm releases
- no automatic releases (I tried)
- typical bugfix means 3-7 PRs now (bugfix, update ui-classic master, update ui-service master, and then 2 PRs per backport), and I can only review the first one, because I'm creating the others (https://github.com/himdel/dotfiles/tree/master/ManageIQ)
- especially in the cases of dialog-user and dialog-editor, there is more logic in ui-classic and ui-service to complement the ui-components part, could be simplified by merging
- originally meant to serve to share angular components between ui-classic and ui-service, but only miq-select and dialog-user are actually used in ui-service
- uses a demo/ folder for examples
- no release branches (the first need to backport something without all the rest came in Make repeatedly searching through Tag Categories and Values work react-ui-components#167), thus no way to backport things
- automatic releases
- but a ui-classic PR still needs to happen to update the version (the only reason the PR count isn't the same is that we can't backport)
- ui-classic is the only user of the repo
- uses storybook for examples (and a demo/ folder)
New state:
Any ui-components component used exclusively by SUI will be moved to SUI:
-
site-switcher: Remove site-switcher ui-components#433, miq-site-switcher - move component from ui-components here manageiq-ui-service#1615
Any ui-components component used exclusively by ui-classic will be moved to ui-classic:
-
common,styles(possibly doesn't need to exist, boilerplate, styles should live with their components) -
dialog-editor([WIP] Move dialog-editor to ui-classic ui-components#436 & [WIP] Move dialog-editor from ui-components #6954) -
fonticon-picker(partly Replace angular-based fonticon picker with a react component #6985) -
gtl(possibly replace by react version ([WIP] Rewrite GTL to react react-ui-components#151), but likely not relevant for backports) -
quadicon -
toolbar- unused (since Toolbar: React rewrite and simplification. #5997), removed in Toolbars - clean up, move remnants to gtl ui-components#434, except for 2 components moved to gtl for the paginator -
tree-selector -
tree-view
Any react-ui-components used exclusively by ui-classic will be moved to ui-classic:
-
amazon-security-form-group- unused, removed in Remove unused AmazonSecurityFormGroup react-ui-components#170 -
dynamic-form- unsued, removed in Remove unused DynamicForm react-ui-components#171 -
forms- removed in Delete the snapshot form and the unnecessary form components react-ui-components#179 (+ Convert the Cloud Subnet Form to DDF and get rid of react-ui-components manageiq-providers-nuage#210, Convert final-form forms to DDF and get rid of react-ui-components manageiq-providers-redfish#107 & Remove unused dependency to react-ui-components manageiq-providers-lenovo#299) (pending TODO,forms/PfSelectwas already copied for tagging, remove once no react-ui-components uses) -
global-functions-sprintfand__, useless once everything is moved -
helpers- only used by rbac-forms, removed in Remove unused rbac-forms, +helpers react-ui-components#172 -
icon-picker- (unused, but relevant Replace Icon picker with a React one #5758 + Replace angular-based fonticon picker with a react component #6985) -
manageiq-validators- only used by rbac-forms, removed in Remove unused manageiq-validators react-ui-components#173 -
quadicon(without react gtls, only used in AggregateStatusCard, but gtls will need it) -
rbac-forms- unused, removed in Remove unused rbac-forms, +helpers react-ui-components#172 -
report-editor- unused, removed in Remove unused report-editor react-ui-components#174 -
table- unused, removed in Remove unused table/ (GenericPreviewTable) react-ui-components#175 -
tagging- Move tagging from react-ui-components #6691, Move tagging to ui-classic react-ui-components#168 -
tagging-pf4- not used at all, removed in Move tagging to ui-classic react-ui-components#168 -
textual_summary -
toolbar -
topology- unused, removed in Remove unused topology react-ui-components#176 -
vm-snapshot-form- removed in Delete the snapshot form and the unnecessary form components react-ui-components#179 + Converted VM Snapshot creation form to DDF #7004) -
wooden-tree- Load react-wooden-tree directly, not through react-ui-components #7417
Unfinished react-ui-components work that should be finished at some point:
- Expression editor - [WIP] Expression Editor react-ui-components#149 & Expression editor react-ui-components#89
- GTL - [WIP] Rewrite GTL to react react-ui-components#151
- Report editor - removed in Remove unused report-editor react-ui-components#174
The rest of ui-components:
-
dialog-user- used by ui-classic and SUI, with almost-copies of the API talking code in the respective repos - merge with that, release as a separate package (or replace by new ddf-based dialog player, if relevant by then) -
miq-select- release as part of the@pf/select(our existing fork ofbootstrap-select, the jquery part of miq-select) (or possibly as part of bootstrap-select itself, which I'm now also a maintainer of)
Documentation:
We should merge the demo & storybook into one place documenting all our components, and add entires for the existing ui-classic ones.
(Currently not sure whether to go with storybook, we don't use the knobs that much, and it comes at the cost of a third separate webpack configuration (in addition to jest).)