Skip to content

Fix travis - jest #5065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mzazrivec merged 2 commits into from
Dec 7, 2018
Merged

Fix travis - jest #5065

mzazrivec merged 2 commits into from
Dec 7, 2018

Conversation

@himdel
Copy link
Contributor

@himdel himdel commented Dec 7, 2018 •
edited
Loading

Fixes..

 FAIL  app/javascript/spec/set-service-ownership-form/set-service-ownership-form.spec.js
  Set service ownership form component
    ✕ encountered a declaration exception (3ms)
  ● Set service ownership form component › encountered a declaration exception
    Cannot spy the miqAjaxButton property because it is not a function; undefined given instead

Caused by #5046 + #5027.

(The latter moved some requires, and the first PR never reran travis after the second was merged.)

CC @ZitaNemeckova @Hyperkid123

himdel added 2 commits December 7, 2018 14:44
@himdel
jest.setup.js - add back whatwg-fetch
4d01704 
moved in #5027
but whatwg-fetch is needed everywhere we touch the API
@himdel
Fix set service ownership form spec
1361077 
it's missing a few globals, adding the helpers
@himdel himdel added the test label Dec 7, 2018
This was referenced Dec 7, 2018
Merged
Merged
@mzazrivec mzazrivec self-assigned this Dec 7, 2018
@miq-bot
Copy link
Member

miq-bot commented Dec 7, 2018

Checked commits https://github.com/himdel/manageiq-ui-classic/compare/4d01704d4cb026067f02d11d5a4de923dd3e0832~...1361077b2af5f4eeea5b93b9030ec175d0185e32 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍪

@mzazrivec mzazrivec added this to the Sprint 101 Ending Dec 17, 2018 milestone Dec 7, 2018
@mzazrivec mzazrivec merged commit 622c35b into ManageIQ:master Dec 7, 2018
@himdel himdel deleted the fix-travis-jest branch December 7, 2018 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@mzazrivec mzazrivec

Labels

test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@himdel @miq-bot @mzazrivec