Skip to content

Move require/mock from jest.setup to helpers #5027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
himdel merged 11 commits into from
Dec 6, 2018
Merged

Move require/mock from jest.setup to helpers #5027

himdel merged 11 commits into from
Dec 6, 2018

Conversation

@ZitaNemeckova
Copy link
Contributor

@ZitaNemeckova ZitaNemeckova commented Dec 3, 2018

Move as much stuff from jest.setup.js to helpers. To make work on #4913 easier :)

@miq-bot add_label wip, test, technical debt, hammer/no

@miq-bot miq-bot changed the title Move require/mock from jest.setup to helpers [WIP] Move require/mock from jest.setup to helpers Dec 3, 2018
@ZitaNemeckova ZitaNemeckova mentioned this pull request Dec 4, 2018
Closed
@ZitaNemeckova ZitaNemeckova force-pushed the cleanup_angular_jest_test branch 2 times, most recently from 3d06291 to 3262950 Compare December 4, 2018 15:15
@ZitaNemeckova ZitaNemeckova force-pushed the cleanup_angular_jest_test branch from 3262950 to 98f6300 Compare December 5, 2018 10:23
@ZitaNemeckova ZitaNemeckova force-pushed the cleanup_angular_jest_test branch from 98f6300 to 70653fb Compare December 5, 2018 12:18
@ZitaNemeckova
Copy link
Contributor Author

ZitaNemeckova commented Dec 5, 2018

@miq-bot remove_label wip

@himdel please have a look :)

@miq-bot miq-bot changed the title [WIP] Move require/mock from jest.setup to helpers Move require/mock from jest.setup to helpers Dec 5, 2018
@miq-bot miq-bot removed the wip label Dec 5, 2018
@himdel
Copy link
Contributor

himdel commented Dec 6, 2018

LGTM,
but since the folder is already called helpers/ let's not add helpers/fooHelper.js and helpers/barHelper.js.

Hint: rename 's/Helper//' files_to_rename and sed -i 's/Helper//' files_to_fix are probably a good place to start ;)

@himdel himdel self-assigned this Dec 6, 2018
@miq-bot
Copy link
Member

miq-bot commented Dec 6, 2018

Checked commits ZitaNemeckova/manageiq-ui-classic@5ea1eaa~...cb88d9a with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🏆

@himdel himdel merged commit 54eb972 into ManageIQ:master Dec 6, 2018
@himdel himdel added this to the Sprint 101 Ending Dec 17, 2018 milestone Dec 6, 2018
@Hyperkid123 Hyperkid123 mentioned this pull request Dec 6, 2018
Merged
This was referenced Dec 7, 2018
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@himdel himdel

Labels

hammer/no technical debt test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ZitaNemeckova @himdel @miq-bot