Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remap :name parameter into :bucket parameter when creating new bucket #198

Merged
merged 1 commit into from
Mar 24, 2017
Merged

Remap :name parameter into :bucket parameter when creating new bucket #198

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion app/models/manageiq/providers/amazon/storage_manager/s3/cloud_object_store_container.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,9 @@ def raw_cloud_object_store_container_clear
end

def self.raw_cloud_object_store_container_create(ext_management_system, options)
options.except!(:name) # name is part of general options, but S3 doesn't like it
# frontend stores name as :name, but amazon expects it as :bucket
options[:bucket] = options.delete(:name) unless options[:name].nil?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, it's strange it expects it as :bucket but returns bucket.name


region = options[:create_bucket_configuration][:location_constraint]
connection = ext_management_system.connect(:region => region)
bucket = connection.create_bucket(options)
Expand Down