Remap :name parameter into :bucket parameter when creating new bucket
#198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current implementation assumes that frontend composes all the options that backend then just sends to AWS. But there is an exception with :name option. While it is needed on frontend (to display flash), it is rejected by AWS. Initial idea was to just remove the :name option here in backend, but turns out that renaming it to :bucket works better. Hence this commit. Signed-off-by: Miha Pleško <miha.plesko@xlab.si>
|
Checked commit miha-plesko@306d930 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
Ladas
reviewed
Mar 24, 2017
| @@ -42,7 +42,9 @@ def raw_cloud_object_store_container_clear | |||
| end | |||
|
|
|||
| def self.raw_cloud_object_store_container_create(ext_management_system, options) | |||
| options.except!(:name) # name is part of general options, but S3 doesn't like it | |||
| # frontend stores name as :name, but amazon expects it as :bucket | |||
| options[:bucket] = options.delete(:name) unless options[:name].nil? | |||
There was a problem hiding this comment.
hm, it's strange it expects it as :bucket but returns bucket.name
|
@miha-plesko looks good, it's a weird naming on the aws side though :-) |
|
Yeah, I'm not smart enough to understand it :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation assumes that frontend composes all the options that backend then just sends to AWS. But there is an exception with :name option. While it is needed on frontend (to display flash), it is rejected by AWS.
Initial idea was to just remove the :name option here in backend, but turns out (see this conversation) that renaming it to :bucket works better. Hence this commit.
@miq-bot add_label enhancement
@miq-bot assign @Ladas