Merge branch 'master' into bja/blocktooltips

CHANGELOG.md

@@ -3,6 +3,16 @@
 ## [Unreleased]
 
 - Add Tooltips for blocks [#4451](https://github.com/MakieOrg/Makie.jl/pull/4451)
+- Prevent more default actions when canvas has focus [#4602](https://github.com/MakieOrg/Makie.jl/pull/4602).
+- Fix an error in `convert_arguments` for PointBased plots and 3D polygons [#4585](https://github.com/MakieOrg/Makie.jl/pull/4585).
+- Fix polygon rendering issue of `crossbar(..., show_notch = true)` in CairoMakie [#4587](https://github.com/MakieOrg/Makie.jl/pull/4587).
+- Fix render order of Axis3 frame lines in CairoMakie [#4591](https://github.com/MakieOrg/Makie.jl/pull/4591)
+
+## [0.21.16] - 2024-11-06
+
+- Added `origin!()` to transformation so that the reference point of `rotate!()` and `scale!()` can be modified [#4472](https://github.com/MakieOrg/Makie.jl/pull/4472)
+- Correctly render the tooltip triangle [#4560](https://github.com/MakieOrg/Makie.jl/pull/4560).
+- Introduce `isclosed(scene)`, conditionally use `Bonito.LargeUpdate` [#4569](https://github.com/MakieOrg/Makie.jl/pull/4569).
 - Allow plots to move between scenes in SpecApi [#4132](https://github.com/MakieOrg/Makie.jl/pull/4132).
 - Added empty constructor to all backends for `Screen` allowing `display(Makie.current_backend().Screen(), fig)` [#4561](https://github.com/MakieOrg/Makie.jl/pull/4561).
 - Added `subsup` and `left_subsup` functions that offer stacked sub- and superscripts for `rich` text which means this style can be used with arbitrary fonts and is not limited to fonts supported by MathTeXEngine.jl [#4489](https://github.com/MakieOrg/Makie.jl/pull/4489).

ReferenceTests/src/tests/examples2d.jl

@@ -707,6 +707,12 @@ end
         strokewidth = 2f0, strokecolor = :cyan
     )
     tooltip!(ax, "i'm an axis", placement=:center)
+    # Test depth (this part is expected to fail in CairoMakie)
+    p = tooltip!(ax, -5, -4, "test line\ntest line", backgroundcolor = :lightblue)
+    translate!(p, 0, 0, 100)
+    mesh!(ax, 
+        Point3f.([-7, -7, -3, -3], [-4, -2, -4, -2], [99, 99, 101, 101]), [1 2 3; 2 3 4], 
+        shading = NoShading, color = :orange)
     fig
 end
 

src/basic_recipes/tooltip.jl

@@ -204,30 +204,6 @@ function plot!(p::Tooltip{<:Tuple{<:VecTypes}})
         overdraw = p.overdraw, depth_shift = p.depth_shift,
         inspectable = p.inspectable, transformation = Transformation()
     )
-    onany(p, bbox, p.triangle_size, p.placement, p.align) do bb, s, placement, align
-        o = origin(bb); w = widths(bb)
-        scale!(mp, s, s, s)
-
-        if placement === :left
-            translate!(mp, Vec3f(o[1] + w[1], o[2] + align * w[2], o[3]))
-            rotate!(mp, qrotation(Vec3f(0,0,1), 0.5pi))
-        elseif placement === :right
-            translate!(mp, Vec3f(o[1], o[2] + align * w[2], o[3]))
-            rotate!(mp, qrotation(Vec3f(0,0,1), -0.5pi))
-        elseif placement in (:below, :down, :bottom)
-            translate!(mp, Vec3f(o[1] + align * w[1], o[2] + w[2], o[3]))
-            rotate!(mp, Quaternionf(0,0,1,0)) # pi
-        elseif placement in (:above, :up, :top)
-            translate!(mp, Vec3f(o[1] + align * w[1], o[2], o[3]))
-            rotate!(mp, Quaternionf(0,0,0,1)) # 0
-        elseif placement === :center
-        else
-            @error "Tooltip placement $placement invalid. Assuming :above"
-            translate!(mp, Vec3f(o[1] + align * w[1], o[2], o[3]))
-            rotate!(mp, Quaternionf(0,0,0,1))
-        end
-        return
-    end
 
     # Outline