remove placement=:center and visible=:always options

src/basic_recipes/tooltip.jl

@@ -9,7 +9,7 @@ Creates a tooltip pointing at `position` displaying the given `string
     text = ""
     "Sets the offset between the given `position` and the tip of the triangle pointing at that position."
     offset = 10
-    "Sets where the tooltip should be placed relative to `position`. Can be `:above`, `:below`, `:left`, `:right`, `:center`."
+    "Sets where the tooltip should be placed relative to `position`. Can be `:above`, `:below`, `:left`, `:right`."
     placement = :above
     "Sets the alignment of the tooltip relative `position`. With `align = 0.5` the tooltip is centered above/below/left/right the `position`."
     align = 0.5
@@ -103,8 +103,6 @@ function plot!(p::Tooltip{<:Tuple{<:VecTypes}})
             return Vec2f(l - align * (l + r), -o - t - ts)
         elseif placement in (:above, :up, :top)
             return Vec2f(l - align * (l + r),  o + b + ts)
-        elseif placement === :center
-            return Vec2f(l - align * (l + r),  b - align * (b + t))
         else
             @error "Tooltip placement $placement invalid. Assuming :above"
             return Vec2f(0, o + b + ts)
@@ -120,8 +118,6 @@ function plot!(p::Tooltip{<:Tuple{<:VecTypes}})
             return (align, 1.0)
         elseif placement in (:above, :up, :top)
             return (align, 0.0)
-        elseif placement === :center
-            return (0.5, 0.5)
         else
             @error "Tooltip placement $placement invalid. Assuming :above"
             return (align, 0.0)
@@ -249,10 +245,6 @@ function plot!(p::Tooltip{<:Tuple{<:VecTypes}})
                 (l + align * w - 0.5s, b),
                 (l, b)
             ]
-        elseif placement === :center
-            Vec2f[
-                (l, b), (l, t), (r, t), (r, b), (l, b)
-            ]
         else
             @error "Tooltip placement $placement invalid. Assuming :above"
             Vec2f[

src/makielayout/blocks.jl

@@ -617,12 +617,11 @@ function REPL.fielddoc(t::Type{<:Block}, s::Symbol)
 end
 
 """
-    function tooltip!(b::Block, str::AbstractString; visible=:always, delay=0, depth=9e3, kwargs...)
+    function tooltip!(b::Block, str::AbstractString; visible=true, delay=0, depth=9e3, kwargs...)
 
-Adds a tooltip to a block.  `visible` can be `:always`, `:hover`, or `:never`.
-`delay` specifies the interval in seconds before the tooltip appears if
-`visible` is `:hover`.  `depth` should be large to ensure that the tooltip is
-in front.  See `tooltip` for more details.
+Adds a tooltip to a block.  `delay` specifies the interval in seconds before the
+tooltip appears if `visible` is `true`.  `depth` should be large to ensure that
+the tooltip is in front.  See `tooltip` for more details.
 
 # Examples
 ```julia-repl
@@ -631,30 +630,28 @@ julia> f = Figure()
 julia> t = Toggle(f[1,1])
 Toggle()
 
-julia> tooltip!(t, "I'm a Toggle", visible = :hover)
+julia> tooltip!(t, "I'm a Toggle")
 Plot{Makie.tooltip, Tuple{Vec{2, Float32}, String}}
 
 julia> b = Button(f[2,1])
 Button()
 
-julia> v = Observable(:never)
-Observable(:never)
+julia> v = Observable(false)
+Observable(false)
 
-julia> tt = tooltip!(b, "I'm a Button", placement = :below, visible = v)
+julia> tt = tooltip!(b, "I'm a Button", placement = :below, visible = v, delay = 1)
 Plot{Makie.tooltip, Tuple{Vec{2, Float32}, String}}
 
-julia> v[] = :always
+julia> v[] = true
 :always
 ```
 """
-function tooltip!(b::Block, str::AbstractString; visible=:always, delay=0, depth=9e3, kwargs...)
+function tooltip!(b::Block, str::AbstractString; visible=true, delay=0, depth=9e3, kwargs...)
     tt = tooltip!(b.blockscene, b.blockscene.events.mouseposition, str; kwargs...)
     translate!(tt, 0, 0, depth)
     t0, last_mp = time(), b.blockscene.events.mouseposition[]
     onany(b.blockscene.events.mouseposition, b.layoutobservables.computedbbox, visible) do mp, bbox, v
-        tt.visible[] = if v == :never
-            false
-        elseif v == :hover
+        tt.visible[] = v &&
             if mp in bbox
                 last_mp in bbox || (t0 = time())
                 last_mp = mp
@@ -663,10 +660,6 @@ function tooltip!(b::Block, str::AbstractString; visible=:always, delay=0, depth
                 last_mp = mp
                 false
             end
-        else
-            v == :always || @error("invalid value for tooltip visible, using :always")
-            true
-        end
     end
     notify(b.blockscene.events.mouseposition)
     return tt

test/makielayout.jl

@@ -553,7 +553,5 @@ end
     t = Toggle(f[1,1])
     tooltip!(t, "I'm a Toggle")
     a, s = scatter(f[1,2], [1,2,3])
-    tooltip!(a, "I'm an Axis", placement = :center)
-    b = Button(f[1,3])
-    tooltip!(b, "I'm a Button", placement = :prints_error_assume_above)
+    tooltip!(a, "I'm an Axis")
 end