Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

properly deprecated to_colormap(cm, n) #1901

Merged
merged 3 commits into from
May 10, 2022
Merged

Conversation

SimonDanisch
Copy link
Member

to_colormap(cm, n) got removed without properly deprecating it, and without actually testing & exporting the new way of doing things (categorical_colors).
This adds an descreptive error to to_colormap(cm, n) and tests, exports and fixes categorical_colors

@SimonDanisch SimonDanisch merged commit 961dc01 into master May 10, 2022
@SimonDanisch SimonDanisch deleted the sd/categorical-colors branch May 10, 2022 13:22
@SimonDanisch
Copy link
Member Author

The original PR: #1723

kunzaatko pushed a commit to kunzaatko/Makie.jl that referenced this pull request May 16, 2022
* properly deprecated to_colormap(cm, n)

* add resample_cmap

* actually mention the breaking change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant