-
-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve inference and caching of draw_mesh #1723
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merged refactor and improve conversions #1743 into this PR, since it was improving similar areas and needed the same fixes.
This includes a few breaking changes:
to_colormap(...)
always returnsVector{RGBAf}
now... Still need to contemplate, if that's a good change, since colormaps should almost never contain alpha - but it spilled over fromto_color
which often contains the alpha so i made sure thatto_color
always returnsUnion{RGBAf, Vector{RGBAf}}
colormap = (colors...,)
isn't accepted anymore)to_colormap(gradient, n)
, since it was very inconsistent and impossible to actually implement. One should useMakie.categorical_colors(gradient, n)
for this.to_xxxx(value) = value
for to_colormap/to_color/etcto_xxx
instead ofconvert_attribute(value, key"xxx")