Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/3682/map navigation improvement #3693

Merged
merged 13 commits into from
Aug 19, 2024

Conversation

IdrisLaabidi
Copy link
Contributor

@IdrisLaabidi IdrisLaabidi commented Aug 14, 2024

Enhanced Camera Controls for Map Navigation

Issue: #3682

Description

Descriptive pull request text, answering:

  • This PR addresses the challenge of improving camera movement and zooming functionalities to provide a navigation experience similar to Google Earth.
  • This incorporates three.js MapControls to provide smooth and intuitive camera controls. The map will now respond more fluidly to user inputs for moving and zooming, closely mimicking the Google Earth experience. Updates to three.js (from version 126 to 156) are performed incrementally to ensure compatibility and stability.

Definition of Done

A PR is only ready for merge once all the following acceptance criteria are fulfilled:

  • Changes have been manually tested
  • All TODOs related to this PR have been closed
  • There are automated tests for newly written code and bug fixes
  • All bugs discovered while working on this PR have been submitted as issues (if not already an open issue)
  • Documentation (GH-pages, analysis/visualization READMEs, parser READMEs, --help, etc.) has been updated (almost always necessary except for bug fixes)
  • CHANGELOG.md has been updated

Development Notes

  • Incremental update of three.js library from version 126 to 156:
    • Update from v126 to v136
    • Update from v136 to v146
    • Update from v146 to v156
  • Integration of three.js MapControls
  • Thorough testing to ensure smooth camera movements and proper zoom functionality

Screenshots or gifs

@IdrisLaabidi IdrisLaabidi added priority:high Set by PO difficulty:medium The difficulty to solve this is not super complex but not easy either labels Aug 14, 2024
@IdrisLaabidi IdrisLaabidi self-assigned this Aug 14, 2024
@IdrisLaabidi IdrisLaabidi linked an issue Aug 14, 2024 that may be closed by this pull request
@@ -10,6 +10,15 @@ and this project adheres to [Semantic Versioning](http://semver.org/)
### Chore 👨‍💻 👩‍💻

- Bump node version from 18 to 20 [#3690](https://github.com/MaibornWolff/codecharta/pull/3690)
- Update Three.js to version 0.156.0 [#3693](https://github.com/MaibornWolff/codecharta/pull/3693)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be removed imo, usually dependency updates are not included in the changelog. Only core packages, like node, that require user attention, are stated. 👍

Copy link
Collaborator

@phanlezz phanlezz Aug 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can add in the "fixed" section, that the configuration "reset camera when changing map" now works as intended💯 seems like this issue was only happening locally for me sometimes

Copy link
Collaborator

@phanlezz phanlezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link

sonarcloud bot commented Aug 19, 2024

Copy link

sonarcloud bot commented Aug 19, 2024

@IdrisLaabidi IdrisLaabidi merged commit f5586c3 into main Aug 19, 2024
7 checks passed
@IdrisLaabidi IdrisLaabidi deleted the feature/3682/map-navigation-improvement branch August 19, 2024 11:17
This was referenced Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty:medium The difficulty to solve this is not super complex but not easy either priority:high Set by PO
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changing map navigation to be closer to something widely used
2 participants