-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/3682/map navigation improvement #3693
Conversation
visualization/CHANGELOG.md
Outdated
@@ -10,6 +10,15 @@ and this project adheres to [Semantic Versioning](http://semver.org/) | |||
### Chore 👨💻 👩💻 | |||
|
|||
- Bump node version from 18 to 20 [#3690](https://github.com/MaibornWolff/codecharta/pull/3690) | |||
- Update Three.js to version 0.156.0 [#3693](https://github.com/MaibornWolff/codecharta/pull/3693) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be removed imo, usually dependency updates are not included in the changelog. Only core packages, like node, that require user attention, are stated. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can add in the "fixed" section, that the configuration "reset camera when changing map" now works as intended💯 seems like this issue was only happening locally for me sometimes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Quality Gate passed for 'CodeCharta Visualization'Issues Measures |
Quality Gate passed for 'CodeCharta Analysis'Issues Measures |
Enhanced Camera Controls for Map Navigation
Issue: #3682
Description
Descriptive pull request text, answering:
Definition of Done
A PR is only ready for merge once all the following acceptance criteria are fulfilled:
Development Notes
Screenshots or gifs