Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing map navigation to be closer to something widely used #3682

Closed
ChristianHuehn opened this issue Aug 9, 2024 · 0 comments · Fixed by #3693
Closed

Changing map navigation to be closer to something widely used #3682

ChristianHuehn opened this issue Aug 9, 2024 · 0 comments · Fixed by #3693
Labels
difficulty:medium The difficulty to solve this is not super complex but not easy either priority:high Set by PO

Comments

@ChristianHuehn
Copy link
Collaborator

ChristianHuehn commented Aug 9, 2024 •
edited
Loading

Feature request

Description

As a user, I want to have moving and zooming the camera close to google earth, so that I can navigate easier.

Acceptance criteria

  • Moving the map should not feel like the map is slipping under my mouse
  • Zooming should work as close as possible to google earth
  • The map should not disappear when it is too big
  • Mouse control should not be changed

Assumptions & Exclusions

Development notes (optional Task Breakdown)

  • We want to achieve this with three.js MapControls https://threejs.org/examples/#misc_controls_map in the demo it works with zoom to camera
  • It is possible that this part is not available in threejs v126 so we would have to update in 10 steps (126>136>146>156)
@ChristianHuehn ChristianHuehn added priority:high Set by PO difficulty:medium The difficulty to solve this is not super complex but not easy either labels Aug 9, 2024
@ChristianHuehn ChristianHuehn mentioned this issue Aug 5, 2024
Open
7 tasks
@phanlezz phanlezz mentioned this issue Aug 12, 2024
Closed
This was referenced Aug 12, 2024
Closed
Merged
@IdrisLaabidi IdrisLaabidi linked a pull request Aug 14, 2024 that will close this issue
Feature/3682/map navigation improvement #3693
Merged
9 tasks
phanlezz added a commit that referenced this issue Aug 16, 2024
@phanlezz
#3682: Modify test file so that it does not contain any more TextGeom…
e2b1f85 
…etry
IdrisLaabidi added a commit that referenced this issue Aug 16, 2024
@IdrisLaabidi
add a changelog entry #3682
2e28169
IdrisLaabidi added a commit that referenced this issue Aug 19, 2024
@IdrisLaabidi
update changelog entry #3682
bc26171
IdrisLaabidi added a commit that referenced this issue Aug 19, 2024
@IdrisLaabidi @phanlezz
Feature/3682/map navigation improvement (#3693)
f5586c3 
* update three.js to version 156

* fixed deprecated imports in some test files

* readjusted light intensity

* updated package-lock.json

* updated snapshots

* additional test fixes

* renaming every instance of threeOrbitControls to threeMapControls

* #3682: Modify test file so that it does not contain any more TextGeometry

* add a changelog entry #3682

* update changelog entry #3682

---------

Co-authored-by: Sebastian Wolf <65733509+phanlezz@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty:medium The difficulty to solve this is not super complex but not easy either priority:high Set by PO
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/3682/map navigation improvement MaibornWolff/codecharta
1 participant
@ChristianHuehn