Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tech: arbitrary change in package-lock.json to test pipeline behaviour #3139

Closed

Conversation

friedrich-roskosch-mw
Copy link
Contributor

Arbitrary change in package-lock.json to test pipeline behaviour

Issue: #

Description

In PR #3136 the steps for Sonar are not executed. This spike is here to test the pipeline behaviour. The theory is that Sonar is not executed when only the package-lock.json changes and not the package.json

Descriptive pull request text, answering:

  • What problem/issue are you fixing?
  • What does this PR implement and how?

Screenshots or gifs

@friedrich-roskosch-mw friedrich-roskosch-mw deleted the tech/0/spike/test-sonar-package-lock branch November 22, 2022 15:02
@friedrich-roskosch-mw
Copy link
Contributor Author

friedrich-roskosch-mw commented Nov 22, 2022

For some reason Sonar now executes in #3136 without changing anything. Oh well.

friedrich-roskosch-mw added a commit that referenced this pull request Jan 12, 2023
add proper error handling
add (bad) if condition for tests in customConfigHelper.ts
friedrich-roskosch-mw added a commit that referenced this pull request Jan 13, 2023
* fix: unit tests not working #3193

update to the babel suite

* chore: remove legacy camera transformation, closes #3139

add proper error handling
add (bad) if condition for tests in customConfigHelper.ts

* chore: remove legacy camera transformation, closes #3193

add proper error handling
add (bad) if condition for tests in customConfigHelper.ts

* chore: bump customView api version #3193

It looks like this has been forgotten in #2880, to better signal incompatibility it is now changed

* remove: checkForLegacyCameraSettingsOfCustomConfig #3193

also revert changes to applyCustomConfigButton.component.ts and uploadCustomConfigButton.component.ts

* docs: update changelog #3193

* revert: un-bump custom config api version #3193
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant