tech: arbitrary change in package-lock.json to test pipeline behaviour #3139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
friedrich-roskosch-mw
deleted the
tech/0/spike/test-sonar-package-lock
branch
|
For some reason Sonar now executes in #3136 without changing anything. Oh well. |
friedrich-roskosch-mw
added a commit
that referenced
this pull request
Jan 12, 2023
add proper error handling add (bad) if condition for tests in customConfigHelper.ts
friedrich-roskosch-mw
added a commit
that referenced
this pull request
Jan 13, 2023
* fix: unit tests not working #3193 update to the babel suite * chore: remove legacy camera transformation, closes #3139 add proper error handling add (bad) if condition for tests in customConfigHelper.ts * chore: remove legacy camera transformation, closes #3193 add proper error handling add (bad) if condition for tests in customConfigHelper.ts * chore: bump customView api version #3193 It looks like this has been forgotten in #2880, to better signal incompatibility it is now changed * remove: checkForLegacyCameraSettingsOfCustomConfig #3193 also revert changes to applyCustomConfigButton.component.ts and uploadCustomConfigButton.component.ts * docs: update changelog #3193 * revert: un-bump custom config api version #3193
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arbitrary change in package-lock.json to test pipeline behaviour
Issue: #
Description
In PR #3136 the steps for Sonar are not executed. This spike is here to test the pipeline behaviour. The theory is that Sonar is not executed when only the package-lock.json changes and not the package.json
Descriptive pull request text, answering:
Screenshots or gifs