Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/2318/rework custom dispatch #2880

Merged
merged 13 commits into from
Jul 29, 2022
Merged

Refactor/2318/rework custom dispatch #2880

merged 13 commits into from
Jul 29, 2022

Conversation

shaman-apprentice
Copy link
Contributor

@shaman-apprentice shaman-apprentice commented Jul 1, 2022 •
edited
Loading

This PR does:

  • remove need for custom dispatch logic
  • remove camera.service
  • remove cameraTarget.service

@shaman-apprentice shaman-apprentice force-pushed the refactor/2318/rework-custom-dispatch branch from f1a9eea to 0bb5e72 Compare July 1, 2022 15:03
@shaman-apprentice shaman-apprentice force-pushed the refactor/2318/rework-custom-dispatch branch from 0bb5e72 to a11d0c3 Compare July 1, 2022 15:27
@shaman-apprentice shaman-apprentice marked this pull request as ready for review July 4, 2022 11:32
ce-bo
ce-bo reviewed Jul 8, 2022
View reviewed changes
Copy link
Collaborator

@ce-bo ce-bo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First review: The removal of dispatching the camera is LGTM. I think now some breaking changes has been introduced unintentionally.

@shaman-apprentice shaman-apprentice force-pushed the refactor/2318/rework-custom-dispatch branch from c01985c to 557f198 Compare July 12, 2022 16:40
Merge remote-tracking branch 'origin/main' into refactor/2318/rework-…
67f6713 
…custom-dispatch

# Conflicts:
#	CHANGELOG.md
#	visualization/app/codeCharta/util/usageDataTracker.spec.ts
ce-bo
ce-bo approved these changes Jul 29, 2022
View reviewed changes
Copy link
Collaborator

@ce-bo ce-bo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sonarcloud
Copy link

sonarcloud bot commented Jul 29, 2022

[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Jul 29, 2022

[CodeCharta Visualization] SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

70.5% 70.5% Coverage
0.0% 0.0% Duplication

@shaman-apprentice shaman-apprentice merged commit a5a13b3 into main Jul 29, 2022
@shaman-apprentice shaman-apprentice deleted the refactor/2318/rework-custom-dispatch branch July 29, 2022 11:54
This was referenced Jan 12, 2023
Closed
Merged
friedrich-roskosch-mw added a commit that referenced this pull request Jan 13, 2023
@friedrich-roskosch-mw
chore: bump customView api version #3193
6da61be 
It looks like this has been forgotten in #2880, to better signal incompatibility it is now changed
friedrich-roskosch-mw added a commit that referenced this pull request Jan 13, 2023
@friedrich-roskosch-mw
Fix/3193/custom config todo due (#3196)
a5842c2 
* fix: unit tests not working #3193

update to the babel suite

* chore: remove legacy camera transformation, closes #3139

add proper error handling
add (bad) if condition for tests in customConfigHelper.ts

* chore: remove legacy camera transformation, closes #3193

add proper error handling
add (bad) if condition for tests in customConfigHelper.ts

* chore: bump customView api version #3193

It looks like this has been forgotten in #2880, to better signal incompatibility it is now changed

* remove: checkForLegacyCameraSettingsOfCustomConfig #3193

also revert changes to applyCustomConfigButton.component.ts and uploadCustomConfigButton.component.ts

* docs: update changelog #3193

* revert: un-bump custom config api version #3193
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ce-bo ce-bo ce-bo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shaman-apprentice @ce-bo