Skip to content

Stop using loop kwarg in asyncio.wait() call (DeprecationWarning) #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 31, 2020
Merged

Stop using loop kwarg in asyncio.wait() call (DeprecationWarning) #327

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
11d9034
Update loop.pyx
Jackenmen Mar 28, 2020
eb0dc18
Remove `loop=` from aio_gather too
Jackenmen Mar 28, 2020
dd3fd5c
Update process.pyx
Jackenmen Mar 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion uvloop/handles/process.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -604,7 +604,7 @@ cdef class UVProcessTransport(UVProcess):

if handle._init_futs:
handle._stdio_ready = 0
init_fut = aio_gather(*handle._init_futs, loop=loop)
init_fut = aio_gather(*handle._init_futs)
init_fut.add_done_callback(
ft_partial(handle.__stdio_inited, waiter))
else:
Expand Down
7 changes: 3 additions & 4 deletions uvloop/loop.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1682,7 +1682,7 @@ cdef class Loop:
uv.SOCK_STREAM, 0, flags,
0) for host in hosts]

infos = await aio_gather(*fs, loop=self)
infos = await aio_gather(*fs)

completed = False
sock = None
Expand Down Expand Up @@ -1908,7 +1908,7 @@ cdef class Loop:
lai = &lai_static

if len(fs):
await aio_wait(fs, loop=self)
await aio_wait(fs)

if rai is NULL:
ai_remote = f1.result()
Expand Down Expand Up @@ -3095,8 +3095,7 @@ cdef class Loop:

shutdown_coro = aio_gather(
*[ag.aclose() for ag in closing_agens],
return_exceptions=True,
loop=self)
return_exceptions=True)

results = await shutdown_coro
for result, agen in zip(results, closing_agens):
Expand Down