Skip to content

Conversation

@Jackenmen
Copy link
Contributor

@Jackenmen Jackenmen commented Mar 28, 2020

Calling loop.create_connection() currently causes Python to send DeprecationWarning, this PR solves it.

// edit: I also removed use of loop kwarg in aio_gather calls
// edit2: Fixes #314

@Jackenmen
Copy link
Contributor Author

Now looking at asyncio.gather's code, the DeprecationWarning doesn't show when it's called with at least one awaitable so I might have done the removal of loop kwarg from aio_gather calls unnecessarily. Let me know if it should stay like that or if I should revert it.

@1st1
Copy link
Member

1st1 commented Mar 31, 2020

Thanks, I think the PR is great!

@1st1 1st1 merged commit 2870219 into MagicStack:master Mar 31, 2020
@Jackenmen Jackenmen deleted the jack1142-patch-1 branch March 31, 2020 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deprecation warning when using uvloop.install in python 3.8

2 participants