Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update automated-tests.yaml #3688

Closed
wants to merge 1 commit into from
Closed

Update automated-tests.yaml #3688

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 22 additions & 14 deletions .github/workflows/automated-tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
# This workflow will do a clean install of node dependencies, build the source code and run tests across different versions of node
# For more information see: https://help.github.com/actions/language-and-framework-guides/using-nodejs-with-github-actions

name: "Run Automated Tests"

on:
Expand All @@ -16,29 +13,35 @@ jobs:
code-style-check:
runs-on: ubuntu-latest
timeout-minutes: 15
strategy:
matrix:
node-version: [20.x, 22.x]
steps:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why should code-style-check run on different node versions?

- name: "Checkout code"
uses: actions/checkout@v4
- name: "Use Node.js"
- name: "Use Node.js ${{ matrix.node-version }}"
uses: actions/setup-node@v4
with:
node-version: 23
node-version: ${{ matrix.node-version }}
cache: "npm"
- name: "Install dependencies"
run: |
npm run install-mm:dev
- name: "Run linter tests"
run: |
npm run test:prettier
npm run test:js
npm run test:css
npm run test:markdown
npm ci
- name: "Run Prettier"
run: npm run test:prettier
- name: "Run JS Linter"
run: npm run test:js
- name: "Run CSS Linter"
run: npm run test:css
- name: "Run Markdown Linter"
run: npm run test:markdown

test:
runs-on: ubuntu-latest
timeout-minutes: 30
strategy:
matrix:
node-version: [20.18.1, 20.x, 22.x, 23.x]
node-version: [20.18.1, 20.x, 22.x]
steps:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you remove node 23?

- name: "Checkout code"
uses: actions/checkout@v4
Expand All @@ -50,10 +53,15 @@ jobs:
cache: "npm"
- name: "Install dependencies"
run: |
npm run install-mm:dev
npm ci
- name: "Run tests"
run: |
Xvfb :99 -screen 0 1024x768x16 &
export DISPLAY=:99
touch css/custom.css
npm run test
- name: "Upload coverage report"
uses: actions/upload-artifact@v3
with:
name: coverage-report
path: coverage/
Loading