-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update automated-tests.yaml #3688
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! 🙂 For better comprehensibility, please adjust the default PR text so that it describes what you have improved.
And please follow the four rules in the PR text. It may seem like a lot at first, but you can do it 🚀
@@ -16,29 +13,35 @@ jobs: | |||
code-style-check: | |||
runs-on: ubuntu-latest | |||
timeout-minutes: 15 | |||
strategy: | |||
matrix: | |||
node-version: [20.x, 22.x] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why should code-style-check run on different node versions?
test: | ||
runs-on: ubuntu-latest | ||
timeout-minutes: 30 | ||
strategy: | ||
matrix: | ||
node-version: [20.18.1, 20.x, 22.x, 23.x] | ||
node-version: [20.18.1, 20.x, 22.x] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you remove node 23?
this PR is based on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please describe what this PR is supposed to do as requested in the PR template
Looks like a fake account, as it has opened similar nonsense PRs in other projects. Example: NVlabs/instant-ngp#1586 🙁 |
Hello and thank you for wanting to contribute to the MagicMirror² project
Please make sure that you have followed these 4 rules before submitting your Pull Request:
Note: Sometimes the development moves very fast. It is highly
recommended that you update your branch of
develop
before creating apull request to send us your changes. This makes everyone's lives
easier (including yours) and helps us out on the development team.
Thanks again and have a nice day!