New Mesh: WC14to60kmL60E3SMv2r02 #584

mark-petersen · 2020-06-01T23:22:02Z

Design discussion Water Cycle mesh, 14km high resolution region.

testing_and_setup/compass/ocean/global_ocean/WC14/init/define_base_mesh.py

testing_and_setup/compass/ocean/global_ocean/WC14/init/config_E3SM_coupling_files.ini

milenaveneziani · 2020-06-02T16:32:36Z

All, I was thinking: since the mesh creation process is BFB for a specific machine (right?), would it make sense to add an entry in the metadata, something like creation_machine, or something like that?

proteanplanet · 2020-06-02T19:25:18Z

@milenaveneziani

All, I was thinking: since the mesh creation process is BFB for a specific machine (right?), would it make sense to add an entry in the metadata, something like creation_machine, or something like that?

I like this idea.

vanroekel · 2020-06-03T22:06:27Z

All as mentioned in #555 I would like to move this forward and focus our discussion / acceptance on the regions of high resolution only. @proteanplanet, @milenaveneziani, @maltrud, @lconlon, and @qingli411 please offer your thoughts on whether these regions are acceptable or if you'd like changes. I would like to move toward testing a first revision by the weekend.

proteanplanet · 2020-06-04T04:26:54Z

I vote to move ahead with WC14. I'll try to slip in the Victoria Island GeoJSON by the weekend, but we should proceed regardless since that's not going to change much. Aside from that, I think we should proceed with all other passages and seas as they are.

xylar · 2020-06-04T09:15:10Z

I'll try to slip in the Victoria Island GeoJSON by the weekend

@proteanplanet, I don't see a feasible way of getting that transect into the mesh in time for a spin-up starting this weekend. Even if you create the geojson file, it would either need to be put in "properly" through geometric_features, requiring a new release of that software and an updated compass environment with that new version of geometric_features or it would need to be included in this mesh as a one-off using #586, which hasn't been reviewed or tested yet by anyone but me.

So my vote is to hold off on transects and include all modifications together in the next iteration of the mesh.

vanroekel · 2020-06-04T13:48:31Z

@proteanplanet I agree with @xylar here. I would like to approve and merge this mesh today based on the regions of high resolution only. This will definitely not be the final e3sm WC mesh and we will revisit transects, passages, islands, in a later revision. Please approve based on the resolution distribution of the mesh alone today. Also cc'ing @milenaveneziani for her approval.

proteanplanet · 2020-06-04T16:00:22Z

@xylar

So my vote is to hold off on transects and include all modifications together in the next iteration of the mesh.

Great. Let's do it.

milenaveneziani · 2020-06-04T16:14:04Z

Resolution looks good to me.

vanroekel · 2020-06-04T16:29:51Z

Thanks all! I'm going to grab this and do the MPAS spin up shortly. @pwolfram and @mark-petersen do you want to push a fix for the mesh gradations noted by @pwolfram in #555? I'm also okay waiting for that for the next revision. I doubt it will make much impact on the large scale flow.

xylar · 2020-06-04T16:38:20Z

@vanroekel, wait just a bit. I pushed the resolution around Norway further north east and I also realized that my fix of the Bering Sea region only went into the 12 km mesh, not the WC14 version. (I didn't realize @mark-petersen made a copy -- I don't think this is what we want to do in the future.)

vanroekel · 2020-06-04T16:39:46Z

@xylar no problem. Let me know when ready.

xylar · 2020-06-04T16:44:16Z

Okay, I pushed my changes. I'm testing them now but if you want to get started, go ahead. I'll let you know if I run into trouble in the base_mesh or culled_mesh stages. You can let me know if you run into trouble but @mark-petersen will likely be more help than me today.

xylar · 2020-06-04T17:28:11Z

The latest images showing resolution and mesh construction steps:

xylar · 2020-06-04T17:44:56Z

@vanroekel, hold off. The problem with the international dateline is still there. I can see it in my plot.

The features have to have different names or only the first is merged in.

It is not working as expected.

xylar · 2020-06-04T18:38:50Z

Once again, the latest images showing resolution and mesh construction steps:

xylar · 2020-06-04T18:47:38Z

Some lessons for COMPASS meshes

@mark-petersen and others who will be working on meshes with geojson regions in the future, here are a few point to keep in mind:

The geojson files need to have points that are strictly between -180 and 180 longitude and -90 and 90 latitude.
Shapes that cross the international date line must have exactly the same points at -180 and at +180 longitude to ensure they are periodic
A given "feature collection" from geometric_features can't have two features with the same name. So the "name" property really should contain something unique and meaningful, not just "region for CUSP mesh". A shape that crosses the international date line will need an "east" and "west" piece with unique names.
A transition in resolution must either be smooth or take place on land. The transition at the Kamchatka Peninsula (once I fixed the Kamchatka region, which was past -180) was not smooth in the ocean and will need to be revisited.

xylar · 2020-06-04T18:48:43Z

@vanroekel, I am finally done for now. I don't think a re-review by any of the others should be needed because the changes I've made were either minor or related to the lack of periodicity at the date line.

vanroekel · 2020-06-04T19:47:10Z

thanks @xylar I'll take this and move toward E3SM testing.

Related to your points above, do you have any suggestions on where we could post those lessons so we don't have to remember they are in this PR later?

xylar · 2020-06-04T20:08:43Z

Related to your points above, do you have any suggestions on where we could post those lessons so we don't have to remember they are in this PR later?

Once #472 gets merged to ocean/develop, I'll be putting together COMPASS documentation. That's the proper place. Until then, I'm just trying to make people aware who happen to be paying attention.

xylar · 2020-06-04T20:09:48Z

@vanroekel and @pwolfram, just FYI I'm still working on getting the Kamchatka Peninsula to look "right" but that will definitely be something for the next iteration.

vanroekel · 2020-06-04T20:12:11Z

Thanks @xylar, that makes perfect sense. I'm starting the spin up of this revision now.

xylar · 2020-06-04T21:25:39Z

I was able to get the Kamchatka Peninsula to transition more abruptly than beofre:

@vanroekel, I'm not going to push any new commits to this branch unless you give the go-ahead. So let me know if/when you would like these changes.

vanroekel · 2020-06-04T21:27:03Z

@xylar if it is easy for you to push now (I know it's getting very late for you) I can pull it in. I was just about to start the spin up

vanroekel · 2020-06-04T21:27:26Z

But I should say I'm fine waiting for the next revision too. I'm happy to go with what's easier for you

xylar · 2020-06-04T21:29:55Z

It's easy to push. Give me a couple minutes to commit.

Two different transition masks are defined, one for east of the peninsula and one for west of it, with a transition right down the center of the peninsula. A key to a smooth transition is that the shapes defining the "east" and "west" regions have the same behavior south of the southern tip of the Peninsula.

xylar · 2020-06-04T21:39:56Z

@vanroekel, okay, I'm done and calling it a night. Thanks for letting me sneak this last bit in.

vanroekel · 2020-06-04T21:41:21Z

Thanks to you as well for the hard work @xylar! I'm going to run the spin up then merge this we can then move deeper analysis to an r03 PR to be opened.

vanroekel · 2020-06-05T16:52:44Z

testing_and_setup/compass/ocean/global_ocean/WC14/spin_up/config_test_final_settings.xml

+
+	<namelist name="namelist.ocean" mode="forward">
+		<template file="template_forward.xml" path_base="script_configuration_dir"/>
+		<template file="template_monthly_output.xml" path_base="script_configuration_dir"/>


@xylar and @mark-petersen this is causing a failure at this stage of the spin up because this line wasn't included in streams below as well, but even doing that template_monthly_output.xml did not include timeSeriesStatsMonthlyRestart. I can make these changes, but my question is if we should do this here, since the xml template doesn't appear to be part of this PR.

@vanroekel, this was part of the reason for an issue I posted in April: #525

In my view, any changes you have to make to config_test_final_settings.xml are fair game for this pull request and hopefully would let us close #525. I would have like to have this addressed in a separate PR but that obviously didn't happen and now is the time. Sorry for the mess!

My suggestion would be to remove timeSeriesStatsMonthlyOutput because:

it doesn't work well unless you run for a full month

it doesn't work well if you don't start at the beginning of a month

spin-up isn't always compatible with running for exactly 1 month prior the test_final_settings stage.

I agree I would prefer to just disable timeSeriesMonthly. I will make the change.

xylar · 2020-06-05T20:01:40Z

Wonderful, nice to have this done! Thanks for shepherding it through, @vanroekel.

…elop Add support for custom critical passages and land blockages #586 This is added to support potential addition of "custom" passages or blockages in #555 and #584. The custom transects could come from a local file or it could be pulled in from geometric_features, e.g. with the merge_features command.

Add WC14 case to compass

01abf5a

mark-petersen added Ocean COMPASS mesh labels Jun 1, 2020

mark-petersen assigned vanroekel Jun 1, 2020

mark-petersen commented Jun 1, 2020

View reviewed changes

testing_and_setup/compass/ocean/global_ocean/WC14/init/define_base_mesh.py Show resolved Hide resolved

xylar reviewed Jun 2, 2020

View reviewed changes

testing_and_setup/compass/ocean/global_ocean/WC14/init/config_E3SM_coupling_files.ini Outdated Show resolved Hide resolved

xylar mentioned this pull request Jun 2, 2020

Add support for custom critical passages and land blockages #586

Merged

Update mesh info in ini file

cdb7ebf

xylar mentioned this pull request Jun 2, 2020

COMPASS: rename e3sm_coupling and move it to be its own test #585

Closed

mark-petersen mentioned this pull request Jun 3, 2020

New Mesh: WC12to60kmL60E3SMv2r01 #555

Merged

Fix periodicity of Bering Sea region

d9e329f

xylar added 3 commits June 4, 2020 18:39

Fix periodicity of Bering Sea region

949139c

Move high-res region south around Norway

929a087

Extend Gulf Stream region further northeast

a21c640

Update mesh metadata

fad1ce2

xylar added 4 commits June 4, 2020 19:57

Shift Kamchatka region by 360 degrees

ce2811e

Name Bering sea halves

f8f54fb

The features have to have different names or only the first is merged in.

Turn off land making at Kamchatka

0fc2245

It is not working as expected.

Update metadata

c556939

xylar added 2 commits June 4, 2020 23:32

Make the resolution plot 300 dpi for easier zooming

1e9c443

xylar approved these changes Jun 5, 2020

View reviewed changes

vanroekel reviewed Jun 5, 2020

View reviewed changes

Removes timeMonthlyOutput from spinup of WC14

c2ad8bf

vanroekel merged commit cc6fd59 into MPAS-Dev:ocean/develop Jun 5, 2020

xylar mentioned this pull request Jul 11, 2020

New Mesh: WC14to60kmL60E3SMv2r03 #628

Merged

mark-petersen deleted the ocean/WC14to60kmL60E3SMv2r02 branch March 3, 2021 13:42

matthewhoffman added COMPASS mesh Ocean labels Mar 17, 2021

New Mesh: WC14to60kmL60E3SMv2r02 #584

New Mesh: WC14to60kmL60E3SMv2r02 #584

Uh oh!

Conversation

mark-petersen commented Jun 1, 2020

Uh oh!

Uh oh!

Uh oh!

milenaveneziani commented Jun 2, 2020

Uh oh!

proteanplanet commented Jun 2, 2020

Uh oh!

vanroekel commented Jun 3, 2020

Uh oh!

proteanplanet commented Jun 4, 2020

Uh oh!

xylar commented Jun 4, 2020

Uh oh!

vanroekel commented Jun 4, 2020

Uh oh!

proteanplanet commented Jun 4, 2020

Uh oh!

milenaveneziani commented Jun 4, 2020

Uh oh!

vanroekel commented Jun 4, 2020

Uh oh!

xylar commented Jun 4, 2020

Uh oh!

vanroekel commented Jun 4, 2020

Uh oh!

xylar commented Jun 4, 2020

Uh oh!

xylar commented Jun 4, 2020

Uh oh!

xylar commented Jun 4, 2020

Uh oh!

xylar commented Jun 4, 2020

Uh oh!

xylar commented Jun 4, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Some lessons for COMPASS meshes

Uh oh!

xylar commented Jun 4, 2020

Uh oh!

vanroekel commented Jun 4, 2020

Uh oh!

xylar commented Jun 4, 2020

Uh oh!

xylar commented Jun 4, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vanroekel commented Jun 4, 2020

Uh oh!

xylar commented Jun 4, 2020

Uh oh!

vanroekel commented Jun 4, 2020

Uh oh!

vanroekel commented Jun 4, 2020

Uh oh!

xylar commented Jun 4, 2020

Uh oh!

xylar commented Jun 4, 2020

Uh oh!

vanroekel commented Jun 4, 2020

Uh oh!

vanroekel Jun 5, 2020

Choose a reason for hiding this comment

Uh oh!

xylar Jun 5, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

xylar Jun 5, 2020

Choose a reason for hiding this comment

Uh oh!

vanroekel Jun 5, 2020

Choose a reason for hiding this comment

Uh oh!

xylar commented Jun 5, 2020

Uh oh!

xylar commented Jun 4, 2020 •

edited

Loading

xylar commented Jun 4, 2020 •

edited

Loading

xylar Jun 5, 2020 •

edited

Loading