Skip to content

Fix hangs in ocean conservation #1086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xylar merged 1 commit into from
Apr 13, 2025
Merged

Fix hangs in ocean conservation #1086

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions mpas_analysis/ocean/conservation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -769,6 +769,9 @@ def _compute_time_series_with_xarray(self, variable_list):
unique_indices = sorted(unique_indices) # Ensure ascending order
ds = ds.isel(Time=unique_indices)

# seeing hanging during saving. Let's try loading
ds.load()

if append:
# Load the existing dataset and combine it with the new dataset
self.logger.info(
Expand All @@ -785,6 +788,9 @@ def _compute_time_series_with_xarray(self, variable_list):
self.logger.info('Sorting by xtime...')
ds = ds.sortby('xtime')

# again, seeing hanging during saving. Let's try loading
ds.load()

# Save the resulting dataset to the output file
self.logger.info(
f'Saving concatenated dataset to {self.outputFile}...')
Expand Down
Loading