Fix hangs in ocean conservation #1086
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A recent change switched to using xarray to concatinate ocean conservation data together. However, recent testing showed hangs if the datasets are not manually loaded. This merge adds 2 places where such manual loads are included.
Collaborator
Author
TestingI was seeing hangs in testing of #1074 without this fix, but was able to successfully run the test suite with this fix include: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent change (#1080) switched to using xarray to concatinate ocean conservation data together. However, recent testing showed hangs if the datasets are not manually loaded. This merge adds 2 places where such manual loads are included.
Checklist
Testingcomment in the PR documents testing used to verify the changes