Skip to content

Conversation

@wpbonelli
Copy link
Member

@wpbonelli wpbonelli commented Feb 3, 2025

Use enums for particle status and event codes, following #2188. Also remove an unnecessary/incorrect termination condition left over from #2185 in the base MethodType%check() routine — stationary particles get terminated at the end of the simulation by the tracking loop with timeout status, previously status 5 (no exit face) was getting reported.

Re: event code naming, I wonder if instead of "ireason", "ievent" might be clearer. The "reason" we're reporting in general is because an event of interest has occurred.. But this would change output headers so maybe best to wait for a non-bugfix release, if any change is to be made.


Checklist of items for pull request

For additional information see instructions for contributing and instructions for developing.

@wpbonelli wpbonelli added bug code refactor Nonfunctional changes labels Feb 3, 2025
@wpbonelli wpbonelli marked this pull request as ready for review February 3, 2025 01:33
@wpbonelli wpbonelli merged commit 16d4e0d into MODFLOW-ORG:develop Feb 3, 2025
20 checks passed
@wpbonelli wpbonelli deleted the enums branch February 3, 2025 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug code refactor Nonfunctional changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant