refactor(prt): use enums for particle status and events #2191
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use enums for particle status and event codes, following #2188. Also remove an unnecessary/incorrect termination condition left over from #2185 in the base
MethodType%check()routine — stationary particles get terminated at the end of the simulation by the tracking loop with timeout status, previously status 5 (no exit face) was getting reported.Re: event code naming, I wonder if instead of "ireason", "ievent" might be clearer. The "reason" we're reporting in general is because an event of interest has occurred.. But this would change output headers so maybe best to wait for a non-bugfix release, if any change is to be made.
Checklist of items for pull request
fprettifyFor additional information see instructions for contributing and instructions for developing.