refactor(gwt-mst): apply enumeration to mst package for readability #2188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christianlangevin
approved these changes
Feb 2, 2025
Contributor
christianlangevin
left a comment
christianlangevin
left a comment
There was a problem hiding this comment.
Looks nice @emorway-usgs. Hope you like the enums. I think it's clearer.
6 tasks
wpbonelli
added a commit
that referenced
this pull request
Feb 3, 2025
Use enums for particle status and event codes, following #2188. Also remove an unnecessary/incorrect termination condition left over from #2185 in the base MethodType%check() routine — stationary particles get terminated at the end of the simulation by the tracking loop with timeout status, previously status 5 (no exit face) was getting reported.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve
MSTcode readability with enumerationESTin pull request fix(gwe-est): add support for energy decay in the solid phase #2155fprettify