Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Atomic-VAEP] use iloc to select last value in the dataframe #750

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

probberechts
Copy link
Member

This commit fixes a bug in the scores and concedes functions in atomic vaep, where the intention is to grab the last element in the dataframe and assign that value to the end of the shifted dataframe.

See also #718
Fixes #749

This commit fixes a bug in the scores and concedes functions in atomic vaep,
where the intention is to grab the last element in the dataframe and assign that
value to the end of the shifted dataframe.

See also #718
Fixes #749
@probberechts probberechts added the bug Something isn't working label Jun 24, 2024
@probberechts probberechts merged commit a9ba54f into master Jun 24, 2024
22 checks passed
@probberechts probberechts deleted the fix/atomic-vaep-iloc branch July 5, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ATOMIC labels issues in 1.5.2
1 participant