Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VAEP] Use iloc to select last value in the dataframe #718

Merged
merged 6 commits into from
Jun 22, 2024
Merged

[VAEP] Use iloc to select last value in the dataframe #718

merged 6 commits into from
Jun 22, 2024

Conversation

abhishekvasu94
Copy link
Contributor

This commit fixes a bug in the scores and concedes functions in vaep, where the intention is to grab the last element in the dataframe and assign that value to the end of the shifted dataframe

@probberechts probberechts added the bug Something isn't working label May 9, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.85%. Comparing base (5f52604) to head (621015f).
Report is 83 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #718      +/-   ##
==========================================
+ Coverage   83.24%   83.85%   +0.60%     
==========================================
  Files          48       48              
  Lines        3677     3710      +33     
  Branches      625      629       +4     
==========================================
+ Hits         3061     3111      +50     
+ Misses        507      489      -18     
- Partials      109      110       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@probberechts probberechts changed the title fix(vaep): use iloc to select last value in the dataframe [VAEP] use iloc to select last value in the dataframe Jun 22, 2024
@probberechts probberechts changed the title [VAEP] use iloc to select last value in the dataframe [VAEP] Use iloc to select last value in the dataframe Jun 22, 2024
@probberechts probberechts merged commit 2cd884c into ML-KULeuven:master Jun 22, 2024
11 checks passed
probberechts added a commit that referenced this pull request Jun 24, 2024
@probberechts
fix(atomic): use iloc to select last value in the dataframe
433513f 
This commit fixes a bug in the scores and concedes functions in atomic vaep,
where the intention is to grab the last element in the dataframe and assign that
value to the end of the shifted dataframe.

See also #718
Fixes #749
@probberechts probberechts mentioned this pull request Jun 24, 2024
Merged
probberechts added a commit that referenced this pull request Jun 24, 2024
@probberechts
fix(atomic): use iloc to select last value in the dataframe
a9ba54f 
This commit fixes a bug in the scores and concedes functions in atomic vaep,
where the intention is to grab the last element in the dataframe and assign that
value to the end of the shifted dataframe.

See also #718
Fixes #749
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abhishekvasu94 @codecov-commenter @probberechts