Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add action and CI #1
Add action and CI #1
Changes from 13 commits
b5b7005
f7206cc
35596d8
35a74f2
de2f0bf
460be65
756ccd3
df8b188
e6a2965
3507808
3125323
1382840
9445cc5
9598c5b
942885a
5c624f0
3621615
8946443
1c6d36c
6bf0b5b
60dcbf9
11c169d
2adafdd
4f8e6ab
63fea93
d2dbdfe
1d5c377
f2c5aef
8ae6f22
7ad6dc4
4b62d48
0d4f536
7a282d2
137f6bc
868c461
55f7727
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure why this special case exists, I thought you could just straight up pip install from git develop?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"develop" pulls from git develop -- "latest" pulls the latest release available on pypi/conda. Is that what you're asking?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ohhhh, calling upgrade again? I think because I have murky memories in the past about having to manually --upgrade to get the latest version, although I never nailed down exactly why.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We pip install from main in a few places in OpenFE and I've never had this problem. Would it be worth seeing if it's not worth it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm confused what you're asking here -- are you asking why
pip --upgrade
, or are you asking to install from github? I was answering the former question. We could install from github forlatest
but I guess I don't quite see why -- especially since I assume we're renamingmaster
at some point?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry my sole question here is about upgrade step overall and whether or not it's necessary to run it.
edit: I've never had to do this before, especially with
pip