Add action and CI #1
Conversation
.github/workflows/gh-ci.yaml
Outdated
| auto-update-conda: true | ||
| show-channel-urls: true | ||
|
|
||
| - name: Setup Python ${{ steps.get-python-version.outputs.python-version }} |
There was a problem hiding this comment.
Why have this branch? pip is still pip whether or not you added it within a conda env or elsewhere?
There was a problem hiding this comment.
Shortcut -- if we really did arrays of:
- pip or conda or mamba
- with or without conda environment
- 3 versions of python
- develop, latest, specified version
- with or without tests
- multiple OSs
We'd have a gazillion tests. So I used the pip/mamba division to substitute for without/with conda environment.
|
Thanks for the comments already, @IAlibay! Any thoughts on it now? |
action.yaml
Outdated
| run: | | ||
| python -m pip install ${{ steps.setup-install-line.outputs.install-line }} | ||
|
|
||
| if [[ ${{ inputs.version }} == "latest" ]] ; then |
There was a problem hiding this comment.
I'm not sure why this special case exists, I thought you could just straight up pip install from git develop?
There was a problem hiding this comment.
"develop" pulls from git develop -- "latest" pulls the latest release available on pypi/conda. Is that what you're asking?
There was a problem hiding this comment.
Ohhhh, calling upgrade again? I think because I have murky memories in the past about having to manually --upgrade to get the latest version, although I never nailed down exactly why.
There was a problem hiding this comment.
We pip install from main in a few places in OpenFE and I've never had this problem. Would it be worth seeing if it's not worth it?
There was a problem hiding this comment.
I'm confused what you're asking here -- are you asking why pip --upgrade, or are you asking to install from github? I was answering the former question. We could install from github for latest but I guess I don't quite see why -- especially since I assume we're renaming master at some point?
There was a problem hiding this comment.
Sorry my sole question here is about upgrade step overall and whether or not it's necessary to run it.
edit: I've never had to do this before, especially with pip
No description provided.