Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-728: Finish the password-change logic #355

Merged
merged 95 commits into from
May 29, 2024
Merged

GH-728: Finish the password-change logic #355

merged 95 commits into from
May 29, 2024

Conversation

utkarshg6
Copy link
Collaborator

No description provided.

@utkarshg6 utkarshg6 linked an issue Oct 11, 2023 that may be closed by this pull request
Finish the password-change logic MASQ-Project/MASQ-Node-issues#728
Closed
@utkarshg6
GH-728: removed the code of the NewPasswordMessage
aec029f
@utkarshg6
GH-728: use ConfigurationChangeMessage while changing password
a39a0c8
@utkarshg6
Merge branch 'master' into GH-728
4ced510
@utkarshg6
GH-728: rename configuration_change_msg_sub_opt to update_min_hops_su…
b376e92 
…b_opt
@utkarshg6
GH-728: rename new_password_subs to update_password_subs
b55577a
@utkarshg6
GH-728: fix wrong name for the actor message
79b6b9a
@utkarshg6
GH-728: send ConfigurationChangeMessage to other actors too
8204b01
@utkarshg6
GH-728: add a TODO
5aa8f0c
@utkarshg6
GH-728: rename to _opt
87dcf89
@utkarshg6
GH-728: implement handler for ConfigurationChange::UpdatePassword ins…
507b130 
…ide Neighborhood
@utkarshg6
Merge branch 'master' into GH-728
4d07e27
@utkarshg6
GH-728: add TODO to implement handler for ConfigurationChange::Update…
04533e4 
…Password inside BlockchainBridge
@utkarshg6
GH-728: add TODO to implement handler for ConfigurationChange::Update…
d59409d 
…Password inside Accountant
@utkarshg6
GH-728: create new struct for UpdatePasswordSubs
c2d0cad
@utkarshg6
GH-728: add the new TODO
6a8086e
@utkarshg6
GH-728: send a ConfigurtionChangeMessage when the consuming wallet is…
3ec34fe 
… generated
@utkarshg6
GH-728: add a test for the panic case
e8edd34
@utkarshg6
GH-728: some refactor changes in configurator.rs
bfcafdb
@utkarshg6
GH-728: test drive the case when the wallet is recovered
2fedf65
@utkarshg6
GH-728: fix some of the tests
90385a5
@utkarshg6
GH-728: fix the remaining 2 failing tests
2bed071
@utkarshg6
GH-728: reorder fields
aef323a
@utkarshg6
GH-728: the received ConfigurationChangeMessage is properly handled
06aea8e
@utkarshg6
Merge branch 'master' into GH-728
595a806
@utkarshg6
GH-728: update the password when necessary
5f50515
@utkarshg6
GH-728: add a todo
1912a1b
@utkarshg6
GH-728: add the ability to synchronise password
6cab5ef
@utkarshg6
GH-728: add ability for accountant to handle an unexpected configurat…
6ecfe83 
…ion change msg
utkarshg6 and others added 22 commits March 6, 2024 13:03
@utkarshg6
GH-728: fix the failing test
a8a4d04
@utkarshg6
GH-728: formatting changes
5d381e4
@utkarshg6
GH-728: remove the earning wallet from ReceivableScannerBuilder
f778208
@utkarshg6
GH-728: check wallet in the begin_scan() for ScannerMock
962ec0a
@utkarshg6
GH-728: remove unnecessary TODO
778d615
@utkarshg6
GH-728: formatting changes
b7243e5
@utkarshg6
GH-728: fix the failing test
bd9ea99
@utkarshg6
Merge branch 'master' into GH-728
8224cc0
@utkarshg6
GH-728: remove unused import in blockchain_interaction_test.rs
8df5537
@utkarshg6
GH-728: BlockchainBridge receives consuming_wallet instead of an Opti…
90dc6fa 
…on<T>
@utkarshg6
GH-728: Check consuming wallet before sending a msg to BlockchainBridge
7211a8f
@utkarshg6
GH-728: remove Option<T> from the wallet_opt param in begin_scan fn
be55fa7
@utkarshg6
GH-728: remove commented out code
c14d9b4
@utkarshg6
GH-728: modify AccountantBuilder to make it's field names contain opt
dec9c3f
@utkarshg6
GH-728: improve test mocks
2a78da9
@utkarshg6
GH-728: introduce another URL for mumbai testnet
3d8b011
@utkarshg6
GH-728: change the message in trace log
ca20828
@utkarshg6
GH-728: test drive the NoConsumingWallet Error
30c4439
@utkarshg6
GH-728: reordering
cd97bdf
@utkarshg6
GH-728: add better logging
f898def
@utkarshg6
GH-728: Review 2 changes
0ed2608
@utkarshg6
GH-728: Review 2 leftover changes
8af33c6
@utkarshg6 utkarshg6 merged commit 2007ccd into master May 29, 2024
6 checks passed
@utkarshg6 utkarshg6 deleted the GH-728 branch May 29, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnwiebe dnwiebe dnwiebe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Finish the password-change logic
2 participants
@utkarshg6 @dnwiebe