Skip to content

Conversation

@bertllll
Copy link
Contributor

@bertllll bertllll commented Oct 9, 2025

Note

Renames pending-failure terms, schedules retry-payables via delayed notifier with configurable interval, corrects retry template amounts to latest payable balance, adds richer debug/warn logging, and updates tests and RPC endpoints.

  • Scanning/Terminology:
    • Rename yet_unproven_failed_payablessuspected_failed_payables; normal_confirmationsstandard_confirmations; update log lines (e.g., "... 0 suspected failures ...").
  • Retry Payables Scheduling:
    • Switch from immediate notify to notify_later with retry_payable_scan_interval (default: half of payable interval); propagate through mocks/tests; reset_scan_timer(&logger).
  • Retry Tx Templates:
    • RetryTxTemplate::new(...) now logs and sets amount_in_wei to the latest payable balance (not additive); constructors updated to accept logger.
  • Pending Payables Scanner:
    • Extra debug logs (harvesting, retry requirement, confirmations/failures processing); renamed helpers accordingly.
  • Payable Scanner:
    • Log failed txs recorded during new-scan handling.
  • Error/Recovery:
    • On ScanError without UI context, attempt to restore scan sequence and log it.
  • Blockchain Interface (Web3):
    • get_transaction_id uses latest (no explicit Pending block); log latest nonce before sending; warn on batch submit failure; tests assert warning.
  • Tests/Integrations:
    • Update multinode and unit tests for new terms, delayed retry scheduling, intervals, and logger params.
    • Add https://eth.llamarpc.com as an additional Ethereum mainnet RPC endpoint in integration tests.

Written by Cursor Bugbot for commit 25af8cb. This will update automatically on new commits. Configure here.

}

pub fn acknowledge_scan_error(&mut self, error: &ScanError, logger: &Logger) {
debug!(logger, "Acknowledging a scan that couldn't finish");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps you could add more details to this log, using the contents of the error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants