GH-598: second QA fix - first review #728
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Renames pending-failure terms, schedules retry-payables via delayed notifier with configurable interval, corrects retry template amounts to latest payable balance, adds richer debug/warn logging, and updates tests and RPC endpoints.
yet_unproven_failed_payables→suspected_failed_payables;normal_confirmations→standard_confirmations; update log lines (e.g.,"... 0 suspected failures ...").notify_laterwithretry_payable_scan_interval(default: half of payable interval); propagate through mocks/tests;reset_scan_timer(&logger).RetryTxTemplate::new(...)now logs and setsamount_in_weito the latest payable balance (not additive); constructors updated to acceptlogger.ScanErrorwithout UI context, attempt to restore scan sequence and log it.get_transaction_iduses latest (no explicit Pending block); log latest nonce before sending; warn on batch submit failure; tests assert warning.https://eth.llamarpc.comas an additional Ethereum mainnet RPC endpoint in integration tests.Written by Cursor Bugbot for commit 25af8cb. This will update automatically on new commits. Configure here.