Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gh-386: formerly panics at double-used "shutdown" ; ended with broad redesign of some structures in masq #3

Merged
merged 373 commits into from
May 22, 2021
Merged
Changes from 1 commit
Commits
Show all changes
373 commits
Select commit Hold shift + click to select a range
8221e9e
GH-325: Removed sccache to see if it makes Actions happier
dnwiebe Dec 15, 2020
922d9bf
GH-325: Added message outlines to messages.rs
dnwiebe Dec 15, 2020
ba18fdd
GH-325: Configurator exists and is beginning to handle messages
dnwiebe Dec 16, 2020
a605240
GH-325: Option<&str> to Option<String>, and got UiCheckPassword working
dnwiebe Dec 16, 2020
5491931
GH-325: Added documentation for UiCheckPassword
dnwiebe Dec 16, 2020
f0f5041
Configurator - change password - is done
bertllll Dec 16, 2020
ff57143
Merge branch 'GH-325p' of https://github.com/MASQ-Project/Node into G…
bertllll Dec 16, 2020
1c8afe6
GH-325: check-password command added to masq
dnwiebe Dec 17, 2020
2687a08
Merge branch 'GH-325p' of github.com:MASQ-Project/Node into GH-325p
dnwiebe Dec 17, 2020
89ec77f
GH-325: Now Configurator just uses a Boxed PersistentConfigurator: no…
dnwiebe Dec 17, 2020
1c06b1c
GH-325: Neighborhood now understands UiNewPasswordBroadcast message, …
dnwiebe Dec 17, 2020
e3263ea
GH-325: Giving back to Dan
bertllll Dec 17, 2020
7749fee
GH-325: End-of-pairing commit for Thursday
dnwiebe Dec 17, 2020
c6347d6
GH-325: Added test for constructor
dnwiebe Dec 17, 2020
e6ce919
GH-325: Tests moved out of actor_system_factory.rs and into dao_utils…
dnwiebe Dec 18, 2020
d416164
GH-325: Formatted, all unit and integration tests passing
dnwiebe Dec 18, 2020
c0f7131
Merged in master
dnwiebe Dec 18, 2020
2b03557
GH-325: Interim commit: reviewing pull request
dnwiebe Dec 18, 2020
573efe8
Review issues
dnwiebe Dec 18, 2020
5053a50
GH-325: Change-pasword for masq is driven in
bertllll Dec 18, 2020
8ee68c2
GH-325: Review issues
dnwiebe Dec 18, 2020
5a968ee
Review issues
dnwiebe Dec 19, 2020
abf52e3
GH-325: Review issues and formatting
dnwiebe Dec 19, 2020
ee3a940
Merged in master
dnwiebe Dec 19, 2020
408215d
Merge branch 'GH-325p' of github.com:MASQ-Project/Node into GH-325p
dnwiebe Dec 19, 2020
d29ad7e
GH-325: Somehow an error message got corrupted
dnwiebe Dec 19, 2020
eca98dd
GH-325: Merged in GH-325p
dnwiebe Dec 19, 2020
34f9c7b
GH-325: Some comments for Bert in masq
dnwiebe Dec 19, 2020
ddfc230
GH-325 Added several messages and a buttload of documentation
dnwiebe Dec 20, 2020
2c473de
Handled UiNewPasswordBroadcast in masq; stopped sending password in U…
dnwiebe Dec 20, 2020
e871444
First generate-wallets test much closer to completion
dnwiebe Dec 20, 2020
7479c8b
GH-325: More progress on generate-wallets. We're going to need to cha…
dnwiebe Dec 20, 2020
043b65c
Change password accepts both versions of this command now
bertllll Dec 20, 2020
e41845a
Merge branch 'GH-325p' of https://github.com/MASQ-Project/Node into G…
bertllll Dec 20, 2020
0153480
GH-325: generate-wallets is now generating the mnemonic phrase
dnwiebe Dec 20, 2020
0a1217b
Merge branch 'GH-325p' of github.com:MASQ-Project/Node into GH-325p
dnwiebe Dec 20, 2020
60cc88d
GH-325: generate-wallet happy path working. Lots of unimplmenteds, an…
dnwiebe Dec 21, 2020
9e7aea3
GH-325: Interface document updated.
dnwiebe Dec 21, 2020
617cbb7
GH-325: Formatting and clippy appeasement.
dnwiebe Dec 21, 2020
baaaba3
GH-325: Removed some unimplementeds
dnwiebe Dec 21, 2020
339a0b3
GH-325:a short commit before pull
bertllll Dec 21, 2020
dec0f42
Merge branch 'GH-325p' of https://github.com/MASQ-Project/Node into G…
bertllll Dec 21, 2020
fbf74fa
GH-325: One more test implemented in configurator
bertllll Dec 21, 2020
a7e479e
GH-325: A bit more from configurator
bertllll Dec 21, 2020
6cfc9a4
GH-325: Formatting, and driving out the rest of the unimplementeds in…
dnwiebe Dec 22, 2020
78460e8
GH-325: To Dan
bertllll Dec 22, 2020
8a58638
GH-325: Over to Bert
dnwiebe Dec 22, 2020
631b957
GH-325: leaving after unproductive thoughts; spent time on untestable…
bertllll Dec 22, 2020
25f51aa
GH-325 Progress on generate-wallets
dnwiebe Dec 22, 2020
c0f9a25
Merge branch 'GH-325p' of github.com:MASQ-Project/Node into GH-325p
dnwiebe Dec 22, 2020
2753df9
GH-325: Merge and formatting
dnwiebe Dec 22, 2020
2dde93e
GH-325: Configurator hooked up; check-password, set-password, and cha…
dnwiebe Dec 23, 2020
933fdf8
GH-325: Little more work on generate-wallets
dnwiebe Dec 24, 2020
ae9e341
GH-325: First test of set_wallet_info
dnwiebe Dec 30, 2020
378a4c3
GH-325: Removed some unimplementeds
dnwiebe Dec 30, 2020
b8ea73b
GH-325: Added a comment
dnwiebe Dec 31, 2020
f76b0d6
GH-325: problem with stringified address solved
bertllll Dec 31, 2020
d51f05c
GH-325: Forgot; removed all unused parts
bertllll Dec 31, 2020
d981f5b
GH-325: set_wallet_info is driven in
dnwiebe Jan 1, 2021
122165a
GH-325: Now set_wallet_info allows resetting the same data
dnwiebe Jan 1, 2021
d568d4c
GH-325: Tests for doomed code removed
dnwiebe Jan 1, 2021
2063b7e
GH-325: Eliminated consuming_wallet_public_key from the codebase; sti…
dnwiebe Jan 1, 2021
411008b
Merge branch 'GH-325-cheat' of github.com:MASQ-Project/Node into GH-3…
dnwiebe Jan 1, 2021
6ed5c29
GH-325: Removed a test that wasn't really a test
dnwiebe Jan 1, 2021
fee9207
GH-325: Removed some dead code
dnwiebe Jan 1, 2021
d21b1e3
GH-325: --consuming-private-key and --earning-wallet are now forbidde…
dnwiebe Jan 1, 2021
c8b666d
GH-325: Removed set_earning_wallet_address()
dnwiebe Jan 2, 2021
de1d847
--generate-wallet and --recover-wallet are deactivated
dnwiebe Jan 2, 2021
6a50742
GH-325: I think all the generation and recovery code is gone now.
dnwiebe Jan 2, 2021
1db2f8a
GH-325: Finally: PersistentConfiguration can now set wallet informati…
dnwiebe Jan 2, 2021
beb7a29
GH-325: generate-wallets seems to be working now
dnwiebe Jan 2, 2021
1424662
GH-325: May be ready for testing
dnwiebe Jan 2, 2021
140e892
GH-325: clippy appeasement for Linux
dnwiebe Jan 2, 2021
51127fa
Don't want to forget about the correction in path
bertllll Jan 2, 2021
109769c
GH-325: appeasing clippy on the Mac this time
dnwiebe Jan 2, 2021
e9ad0c4
Merge branch 'GH-325' of github.com:MASQ-Project/Node into GH-325
dnwiebe Jan 2, 2021
cbf8af9
Appeasing clippy for the Mac
dnwiebe Jan 2, 2021
bf13026
GH-325: Another clippy objection from the Mac addressed
dnwiebe Jan 2, 2021
1e9cd70
GH-325: Formatting
dnwiebe Jan 2, 2021
7dd5307
GH-325: Review issues
dnwiebe Jan 3, 2021
6451aac
UiConfigurationRequest and UiConfigurationResponse handled on the Nod…
dnwiebe Jan 4, 2021
a40dffd
GH-282: configuration command should be working in masq
dnwiebe Jan 4, 2021
811018b
GH-229: Merged in master
dnwiebe Jan 25, 2021
c890c74
GH-229: Adjustment
dnwiebe Jan 28, 2021
cd7158d
GH-229: fixes of the node descriptor string format and other stuff
bertllll Jan 30, 2021
c026ff1
GH-229: last check before Actions
bertllll Jan 30, 2021
0c9afb0
GH-229 - Review issues
dnwiebe Feb 6, 2021
33f0ac1
GH-392: all fixed and ready for the final test
bertllll Feb 8, 2021
8c06176
GH-386: now actions
bertllll Feb 8, 2021
87f1d3d
GH-386: forgot about...s
bertllll Feb 8, 2021
f2748ce
GH-386: rewording
bertllll Feb 9, 2021
eac37c9
Merge branch 'master' into GH-386
dnwiebe Feb 11, 2021
b66b1fe
GH-386: unexpected messages with Node not running unificated as conve…
bertllll Feb 11, 2021
c62ffc4
Merge branch 'GH-386' of https://github.com/MASQ-Project/Node into GH…
bertllll Feb 11, 2021
5d432b6
GH-386: deamon\mod cleaup and let's leap over elsewhere
bertllll Feb 11, 2021
f189507
GH-386: removed unnecessary code; ready for a final decision about wh…
bertllll Feb 11, 2021
a2901db
GH-386: Dispatcher for unexpected conversation and FF messages implem…
bertllll Feb 12, 2021
c9f28da
Merge branch 'master' into GH-386
bertllll Feb 12, 2021
360bfbd
GH-386: broadcast handler now knows what to do with the new message
bertllll Feb 12, 2021
7e27a9b
GH-386: format and lint
bertllll Feb 12, 2021
6834d50
GH-386: ducumentation to UIv2 p. added
bertllll Feb 12, 2021
ac4f5cf
GH-386: Intergration test appeased
bertllll Feb 13, 2021
d28ec65
GH-386: works but I'm not satisfied, also a new bug
bertllll Feb 14, 2021
d98bd4d
GH-386: essentials finalized; needs a decision of what else
bertllll Feb 16, 2021
2d78f8f
GH-392: Clippy argue about unnecessary wraps anew
bertllll Feb 16, 2021
32e8bdc
GH-386: Some renaming
dnwiebe Feb 19, 2021
fd0d045
GH-386: Message change, maybe a rename too
dnwiebe Feb 19, 2021
3dc8349
GH-386: Partial test written
dnwiebe Feb 19, 2021
271891f
GH-386: De-languishing a branch
dnwiebe Mar 11, 2021
db5c063
GH-386: Merged in master
dnwiebe Mar 18, 2021
71587f8
GH-386: Minor cleanup
dnwiebe Mar 19, 2021
2eeaee9
GH-386: synchronizer almost implemented; next it needs some additions…
bertllll Mar 20, 2021
ddf0217
GH-386: correction; from now synchronizer works indeed
bertllll Mar 20, 2021
1d13e2f
GH-386: broadcast handlers have checks for synchronization now
bertllll Mar 20, 2021
b0ce0d8
GH-386: finalized
bertllll Mar 20, 2021
0de6f83
GH-386: another test in main; interface documentation adjusted
bertllll Mar 21, 2021
95ed8ff
GH-386: synchronization between test fn parts
bertllll Mar 21, 2021
82ee748
GH-386: trying with firewall being off
bertllll Mar 21, 2021
0fd6f55
GH-386: firewall stuff canceling; modifying the crashing test
bertllll Mar 21, 2021
632b732
GH-386: formatting
bertllll Mar 21, 2021
dbe77b3
GH-386: trying magic with Win
bertllll Mar 21, 2021
9602cc1
GH-386: tricky visibility
bertllll Mar 21, 2021
51d1583
GH-386: win trick again, hopefuly more info provided
bertllll Mar 22, 2021
8675b6f
GH-386: test rearrangement
bertllll Mar 22, 2021
00a38b3
GH-386: fixing and hardening
bertllll Mar 22, 2021
644d8cb
GH-386: correction and one test dragging down - no real need
bertllll Mar 23, 2021
d8fad96
GH-386: trying to synchronize line_reader
bertllll Mar 24, 2021
44f8ce4
GH-386: starting to implement my spike
bertllll Mar 26, 2021
f3b1172
GH-386: TerminalWrapper; some tests added
bertllll Mar 27, 2021
63d7199
GH-386: continuing integration; compiling; tests failing
bertllll Mar 27, 2021
e5168d0
GH-386: attempts to make the new tool more handy
bertllll Mar 27, 2021
45c7c37
GH-386: old tests are happy with the new componnents
bertllll Mar 27, 2021
71d7ef0
GH-386: ongoing integration
bertllll Mar 28, 2021
1b32d89
GH-386: Started rearranging line_reader
bertllll Mar 28, 2021
e6b7835
GH-386: new occurence of 'send safely' warning; back up before the ne…
bertllll Mar 29, 2021
3985dcb
GH-386: quite close; a few failing tests left
bertllll Mar 30, 2021
851551a
GH-386: before I know how to fix the integration test
bertllll Mar 31, 2021
c34025a
GH-386: I have an inkling...but...
bertllll Mar 31, 2021
4c1ba03
GH-386: Refactored a bit
bertllll Apr 1, 2021
94f2838
GH-386: Backup point before redesigning TerminalWrapper
bertllll Apr 2, 2021
b260e5c
GH-386: back-up...share_point is not shared properly between threads;…
bertllll Apr 3, 2021
6d5a398
GH-386: feels better now; still need to check why exactly
bertllll Apr 3, 2021
5cdb2e8
GH-386: problem discovered; will continue tomorrow
bertllll Apr 3, 2021
40f49bd
GH-386: mostly okay
bertllll Apr 4, 2021
1e915ac
GH-386: clean-up before stepping in new version of Rust
bertllll Apr 4, 2021
85c3d88
Merge branch 'clippy' of https://github.com/MASQ-Project/Node into cl…
bertllll Apr 4, 2021
098cc71
GH-386: formatting
bertllll Apr 4, 2021
55aecc3
GH-386: complaining in an unrelated place
bertllll Apr 5, 2021
05be73a
GH-386: I forgot mut there
bertllll Apr 5, 2021
02ba6d1
GH-386: Test massage
dnwiebe Apr 5, 2021
40d8fe2
GH-386: all planned tests except one possible optimatization
bertllll Apr 5, 2021
3555bc5
GH-386: sudden issue in multinode tests
bertllll Apr 6, 2021
e43d289
GH-386: formatting
bertllll Apr 6, 2021
fc9b3a7
GH-386: another stuff belonging to multinode tests
bertllll Apr 6, 2021
1aafa41
GH-386: sometimes this test is less precise, but still legit
bertllll Apr 6, 2021
43fcd4c
recoverWallets_opcode_fix: opcode changed + new clippy
dnwiebe Mar 29, 2021
d4b8a56
GH-386: backup before an attempt to create widely shareable Streams
bertllll Apr 8, 2021
0a66a4a
GH-386: shared streams across more threads is not a good idea; implem…
bertllll Apr 8, 2021
c7f6dfb
GH-386: test coverage probably completed
bertllll Apr 9, 2021
d33aa10
GH-386: eliminating an integration test with no future; we'll have to…
bertllll Apr 10, 2021
62325d3
GH-386: platform specific code in utils.rs
bertllll Apr 10, 2021
3b1755b
GH-386: help should work now correctly
bertllll Apr 10, 2021
2481987
GH-386: tests' adjustment, timing
bertllll Apr 10, 2021
859ec26
GH-386: timing; trying another pole
bertllll Apr 10, 2021
d8d0fdb
GH-386: trying to make this kind of synchronization test more bulletp…
bertllll Apr 11, 2021
a2cde8b
GH-386: another test adjustment
bertllll Apr 11, 2021
d4c7058
GH-386: unused imports
bertllll Apr 11, 2021
61507e7
GH-386: improvized debugging in Actions - Win
bertllll Apr 11, 2021
8698138
GH-386: trying to stabilize this test for the future
bertllll Apr 12, 2021
01e6d02
GH-386: get_string() adjustment + general clean-up
bertllll Apr 12, 2021
90754a4
GH-386: damn, unused import
bertllll Apr 12, 2021
821d36e
GH-386: test tools prepared for tomorrow
bertllll Apr 12, 2021
d5a24b3
GH-386: finalized
bertllll Apr 14, 2021
7098eab
GH-386: linux specific test assertion
bertllll Apr 14, 2021
b7c86c9
GH-386: actually the last issue has been more specific to Windows tha…
bertllll Apr 14, 2021
50bdfb6
GH-386: recoverWallets fix merged in
bertllll Apr 15, 2021
88334cd
GH-386: hopefully this is gonna have some effect on Actions
bertllll Apr 15, 2021
4bbdacf
GH-386: first part of after-review rework
something Apr 19, 2021
2dbc673
GH-386: another part required by the review
bertllll Apr 21, 2021
25bae1e
GH-386: continuing to resolve issues that we found during the review
bertllll Apr 21, 2021
de6712a
GH-386: another batch of patches and improvements
bertllll Apr 22, 2021
2c00d84
GH-386: probably before the last commit linked to the first round of …
bertllll Apr 23, 2021
29b4e3b
GH-386: Last batch for the 1st review
bertllll Apr 24, 2021
5abd2e3
GH-386: Added documentation and .gitignore lines for Azure
dnwiebe Apr 25, 2021
db131fd
Merge branch 'GH-386' of github.com:MASQ-Project/Node into GH-386
dnwiebe Apr 25, 2021
2e4773a
GH-386: One test changed
bertllll Apr 25, 2021
7a29ebe
Merge branch 'GH-386' of https://github.com/MASQ-Project/Node into GH…
bertllll Apr 25, 2021
16d4963
GH-386: some work for failing tests in actions
bertllll Apr 25, 2021
3b6804a
GH-386: trying to make the crucial test more reliable
bertllll Apr 25, 2021
1b1022d
GH-386: compromise
bertllll Apr 26, 2021
7b3e642
GH-386: up to mock websocketserver
bertllll Apr 30, 2021
f3c9beb
GH-386: Start fourth pass here
dnwiebe Apr 30, 2021
c721d79
Merge branch 'GH-386' of github.com:MASQ-Project/Node into GH-386
dnwiebe Apr 30, 2021
143bab1
Revert "GH-386: Start fourth pass here"
dnwiebe Apr 30, 2021
ecd6eb4
GH-286: No--start fourth pass here
dnwiebe Apr 30, 2021
28608b2
GH-386: trying to refactor non-interactive + fix of extract subcommand
bertllll Apr 30, 2021
0deaad8
Merge branch 'GH-386' of https://github.com/MASQ-Project/Node into GH…
bertllll Apr 30, 2021
a2a2a90
GH-386: MockWebSocketServer functionality broadening + clap factory f…
bertllll May 3, 2021
047998b
GH-386: test finished to its end
bertllll May 3, 2021
57925cb
GH-386: fixed up to round 5; except Dan's part
bertllll May 4, 2021
3dee79c
GH-386: MockWebsocketServer gained some weight and looks more healthy
bertllll May 5, 2021
3520c23
GH-386: refactoring; mostly review 5
bertllll May 6, 2021
84ef725
GH-386: just debugging through Actions; needs more work
bertllll May 7, 2021
dd317cc
GH-386: after-review + more descriptive debugging of the same test as…
bertllll May 7, 2021
6d4b300
GH-386: I left some garabage there
bertllll May 7, 2021
8ebc010
GH-386: another way of looking that; still debugging
bertllll May 7, 2021
dab4898
GH-386: empty; just trying to get Actions working
bertllll May 8, 2021
a45cbc2
GH-386: trying to ignore connection reset
bertllll May 8, 2021
3a3d0ce
GH-386: new clippy in 'node' appeased; quitting debugging in MWSS
bertllll May 8, 2021
f41708e
GH-386: forgot some stuff there
bertllll May 8, 2021
5245a1d
GH-386: new Clippy, a few changes, some maybe needless (in multinodes)
bertllll May 8, 2021
fbe5117
GH-386: need to see logs for Mac again
bertllll May 8, 2021
c552f78
Merge branch 'GH-386' of github.com:MASQ-Project/Node into GH-386
bertllll May 8, 2021
daf3f67
GH-386: attempt on rustup Win fix; time-out correction receive MWSS
bertllll May 9, 2021
7931156
GH-386: rustup self-update was a bad idea
bertllll May 9, 2021
bc1d26e
GH-386: fixes in reciever making integration tests flow nicely again
bertllll May 10, 2021
d015734
GH-386: adjustment MWSS
bertllll May 10, 2021
994a2af
GH-386: formating grrr
bertllll May 10, 2021
583245f
GH-386: small changes in MWSS + clippy Mac
bertllll May 10, 2021
d1cc0c6
GH-386: oh no, formatting
bertllll May 10, 2021
552ec2a
GH-386: refactoring; before trying to throw away 'InterfaceWrapper'
bertllll May 11, 2021
33ff53b
GH-386: details
bertllll May 11, 2021
1163c38
GH-386: cleaning up unnecessary markers etc
bertllll May 12, 2021
cd81a9d
GH-386: grrr, formatting
bertllll May 12, 2021
9868511
GH-386: trying if we can have a pass on other platforms without 'Conn…
bertllll May 12, 2021
d57e6ce
GH-386: 8th review should end by this moment
bertllll May 12, 2021
751e562
GH-386: maybe final arrangement
bertllll May 13, 2021
3daac04
GH-386: Added subscription language to USER-INTERFACE-INTERFACE.md
dnwiebe May 13, 2021
6514a43
GH-386: answering 9th review
bertllll May 14, 2021
1b603f4
Merge branch 'GH-386' of github.com:MASQ-Project/Node into GH-386
bertllll May 14, 2021
6dd0669
Merge branch 'master' into GH-386
dnwiebe May 14, 2021
2acfc8e
GH-386: adding test I forgot to and first half of fixing echo off
bertllll May 14, 2021
b60f9bd
GH-386: additional integration test and fix for 'echo off'
bertllll May 14, 2021
0cfdad3
Merge branch 'GH-386' of github.com:MASQ-Project/Node into GH-386
bertllll May 14, 2021
ea6cb01
GH-386: windows cfg
bertllll May 14, 2021
c9616c0
GH-386: better arrangement in imports and one comment in masq_lib
bertllll May 17, 2021
75a1353
GH-386: grrr, formatting
bertllll May 17, 2021
721d573
GH-386: information for debugging added
bertllll May 19, 2021
b1987e0
GH-386: MWS switching to the logging mode
bertllll May 19, 2021
c66df8b
GH-386: Trying to see why updating rustup is failing
dnwiebe May 19, 2021
a1fa0c2
GH-386: Moved instrumentation to different place
dnwiebe May 19, 2021
ba4e028
GH-386: macOS doesn't allow rustup self updating? What?
dnwiebe May 19, 2021
fa9bbff
GH-386: Trying to separate macOS from Windows and Linux concerning ru…
dnwiebe May 19, 2021
6b96223
GH-386: No more rustup self update, but manually suppressing self-upd…
dnwiebe May 19, 2021
4a4424f
GH-386: in MWS, macOs has more time to wait for the response now
bertllll May 19, 2021
98b4611
Merge branch 'GH-386' of github.com:MASQ-Project/Node into GH-386
bertllll May 19, 2021
a16be87
GH-386: logging removed
bertllll May 19, 2021
a0cbc08
GH-386: final refactoring
bertllll May 20, 2021
26f2e0e
GH-386: a few suggestions addressed
bertllll May 20, 2021
7349c81
GH-386: one test is obsolete
bertllll May 20, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
GH-386: Added subscription language to USER-INTERFACE-INTERFACE.md
  • Loading branch information
dnwiebe committed May 13, 2021
commit 3daac0480d19b5cae08ab6b80ca9785f58934765
5 changes: 4 additions & 1 deletion USER-INTERFACE-INTERFACE.md
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,10 @@ all of them, or some compromise scheme, serves to fix the context and bind toget
response or responses.

In `MASQNode-UIv2`, all responses to a particular conversational request will always have the same opcode
as that request.
as that request. In situations where responses to a particular request can have different meanings (for
example, in the case where the request is a subscription to a class of messages), all the responses will
have the same opcode, but another common field in the responses may be chosen to act as a secondary opcode
to distinguish them from one another.

Some messages are always isolated, and never part of any conversation, like the Broadcast in step 5 above.
These messages will be identifiable by their `opcode`, and their `contextId` should be ignored. (In the
Expand Down