Gh-386: formerly panics at double-used "shutdown" ; ended with broad redesign of some structures in masq #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and Configurator fails because it doesn't
….rs and accountant/mod.rs
…iNewPassword message; started UiGenerateWalletsRequest
dnwiebe
approved these changes
May 14, 2021
dnwiebe
reviewed
May 17, 2021
FinsaasGH
added a commit
that referenced
this pull request
Nov 26, 2021
* GH-418: Updated copyright tag in 230 files & updated authors * GH-418: Updated copyright tag in 5 more files * GH-457: Remove dead parameter processing (#58) * GH-457: Initial cleanup of dead parameter processing. node_configurator_standard.rs and mod.rs only * GH-457: Pairing review with Dan - added initialize_database and allied tests back in * GH-457: Pairing review with Dan - added initialize_database and allied tests back in * GH-457: Pairing review with Dan - added initialize_database and allied tests back in * Delete test.txt * GH-457: Pulled commits from master, removed check_past_initialization and tests, removed TODO regarding request_existing_db_password. Removing it starts a chain of events resulting in node_configurator no longer working. * GH-457: Removed unused import. * GH-457: Removed request_existing_db_password and associated code, refactored get_db_password to pull from persistent config, removed associated tests * GH-457: Restored 2 removed tests * GH-457: Removal of streams and conflicted code. * GH-457: Updated tests and calls to run_modes_factories.rs * GH-457: removed unnecessary validators * Update and rename ci-matrix.yml to ci-ubuntu-latest.yml * Update ci-ubuntu-latest.yml * Create ci-windows-latest.yml * Create ci-macOS-latest.yml * Delete ci-windows-latest.yml * Delete ci-macOS-latest.yml * Update and rename ci-ubuntu-latest.yml to ci-matrix.yml * GH-457: Updated command_processor.rs with new clippy requirements Co-authored-by: FinsaasGH <Odinallfather123> Co-authored-by: FinsaasGH <verumeritde@protonmail.com> Co-authored-by: FinsaasGH <finsaasgh@protonmail.com> * GH-418: Updated Copyright tag to reflect changes requested. Updated license with correct syntax. * GH-414: Change default mnemonic phrase to 12 (#59) * GH-414: Updated generate wallets to use 12 word mnemonic phrase as default * Updated command processor with new clippy changes Co-authored-by: FinsaasGH <Odinallfather123> Co-authored-by: dnwiebe <dnwiebe@gmail.com> * GH-418: Updated daemon_and_node_modes_version_call to 2021/12/31 Co-authored-by: FinsaasGH <Odinallfather123> Co-authored-by: FinsaasGH <verumeritde@protonmail.com> Co-authored-by: FinsaasGH <finsaasgh@protonmail.com> Co-authored-by: dnwiebe <dnwiebe@gmail.com>
bertllll
added a commit
that referenced
this pull request
Dec 3, 2021
* GH-457 (#1) * GH-457: Initial cleanup of dead parameter processing. node_configurator_standard.rs and mod.rs only * GH-457: Pairing review with Dan - added initialize_database and allied tests back in * GH-457: Pairing review with Dan - added initialize_database and allied tests back in * GH-457: Pairing review with Dan - added initialize_database and allied tests back in * Delete test.txt * GH-457: Pulled commits from master, removed check_past_initialization and tests, removed TODO regarding request_existing_db_password. Removing it starts a chain of events resulting in node_configurator no longer working. * GH-457: Removed unused import. * GH-457: Removed request_existing_db_password and associated code, refactored get_db_password to pull from persistent config, removed associated tests * GH-457: Restored 2 removed tests * GH-457: Removal of streams and conflicted code. * GH-457: Updated tests and calls to run_modes_factories.rs * GH-457: removed unnecessary validators * Update and rename ci-matrix.yml to ci-ubuntu-latest.yml * Update ci-ubuntu-latest.yml * Create ci-windows-latest.yml * Create ci-macOS-latest.yml * Delete ci-windows-latest.yml * Delete ci-macOS-latest.yml * Update and rename ci-ubuntu-latest.yml to ci-matrix.yml * GH-457: Updated command_processor.rs with new clippy requirements Co-authored-by: FinsaasGH <Odinallfather123> Co-authored-by: FinsaasGH <verumeritde@protonmail.com> Co-authored-by: FinsaasGH <finsaasgh@protonmail.com> * GH-414: Updated generate wallets to use 12 word mnemonic phrase as default (#2) Co-authored-by: FinsaasGH <finsaas@protonmail.com> * Revert "GH-414: Updated generate wallets to use 12 word mnemonic phrase as default (#2)" This reverts commit d646da9. * Revert "GH-457 (#1)" This reverts commit ed718c4. * Updated command processor with new clippy changes * GH-457 (#4) * GH-457: Initial cleanup of dead parameter processing. node_configurator_standard.rs and mod.rs only * GH-457: Pairing review with Dan - added initialize_database and allied tests back in * GH-457: Pairing review with Dan - added initialize_database and allied tests back in * GH-457: Pairing review with Dan - added initialize_database and allied tests back in * Delete test.txt * GH-457: Pulled commits from master, removed check_past_initialization and tests, removed TODO regarding request_existing_db_password. Removing it starts a chain of events resulting in node_configurator no longer working. * GH-457: Removed unused import. * GH-457: Removed request_existing_db_password and associated code, refactored get_db_password to pull from persistent config, removed associated tests * GH-457: Restored 2 removed tests * GH-457: Removal of streams and conflicted code. * GH-457: Updated tests and calls to run_modes_factories.rs * GH-457: removed unnecessary validators * Update and rename ci-matrix.yml to ci-ubuntu-latest.yml * Update ci-ubuntu-latest.yml * Create ci-windows-latest.yml * Create ci-macOS-latest.yml * Delete ci-windows-latest.yml * Delete ci-macOS-latest.yml * Update and rename ci-ubuntu-latest.yml to ci-matrix.yml * GH-457: Updated command_processor.rs with new clippy requirements Co-authored-by: FinsaasGH <finsaas@protonmail.com> Co-authored-by: FinsaasGH <verumeritde@protonmail.com> Co-authored-by: FinsaasGH <finsaasgh@protonmail.com> * GH-414: Updated generate wallets to use 12 word mnemonic phrase (#5) * GH-414: Updated generate wallets to use 12 word mnemonic phrase as default * Updated command processor with new clippy changes * GH-457: Remove dead parameter processing (#58) * GH-457: Initial cleanup of dead parameter processing. node_configurator_standard.rs and mod.rs only * GH-457: Pairing review with Dan - added initialize_database and allied tests back in * GH-457: Pairing review with Dan - added initialize_database and allied tests back in * GH-457: Pairing review with Dan - added initialize_database and allied tests back in * Delete test.txt * GH-457: Pulled commits from master, removed check_past_initialization and tests, removed TODO regarding request_existing_db_password. Removing it starts a chain of events resulting in node_configurator no longer working. * GH-457: Removed unused import. * GH-457: Removed request_existing_db_password and associated code, refactored get_db_password to pull from persistent config, removed associated tests * GH-457: Restored 2 removed tests * GH-457: Removal of streams and conflicted code. * GH-457: Updated tests and calls to run_modes_factories.rs * GH-457: removed unnecessary validators * Update and rename ci-matrix.yml to ci-ubuntu-latest.yml * Update ci-ubuntu-latest.yml * Create ci-windows-latest.yml * Create ci-macOS-latest.yml * Delete ci-windows-latest.yml * Delete ci-macOS-latest.yml * Update and rename ci-ubuntu-latest.yml to ci-matrix.yml * GH-457: Updated command_processor.rs with new clippy requirements Co-authored-by: FinsaasGH <verumeritde@protonmail.com> Co-authored-by: FinsaasGH <finsaasgh@protonmail.com> Co-authored-by: FinsaasGH <verumeritde@protonmail.com> Co-authored-by: FinsaasGH <finsaasgh@protonmail.com> Co-authored-by: dnwiebe <dnwiebe@gmail.com> * GH-418: Change copyright tags (#3) * GH-418: Updated copyright tag in 230 files & updated authors * GH-418: Updated copyright tag in 5 more files * GH-457: Remove dead parameter processing (#58) * GH-457: Initial cleanup of dead parameter processing. node_configurator_standard.rs and mod.rs only * GH-457: Pairing review with Dan - added initialize_database and allied tests back in * GH-457: Pairing review with Dan - added initialize_database and allied tests back in * GH-457: Pairing review with Dan - added initialize_database and allied tests back in * Delete test.txt * GH-457: Pulled commits from master, removed check_past_initialization and tests, removed TODO regarding request_existing_db_password. Removing it starts a chain of events resulting in node_configurator no longer working. * GH-457: Removed unused import. * GH-457: Removed request_existing_db_password and associated code, refactored get_db_password to pull from persistent config, removed associated tests * GH-457: Restored 2 removed tests * GH-457: Removal of streams and conflicted code. * GH-457: Updated tests and calls to run_modes_factories.rs * GH-457: removed unnecessary validators * Update and rename ci-matrix.yml to ci-ubuntu-latest.yml * Update ci-ubuntu-latest.yml * Create ci-windows-latest.yml * Create ci-macOS-latest.yml * Delete ci-windows-latest.yml * Delete ci-macOS-latest.yml * Update and rename ci-ubuntu-latest.yml to ci-matrix.yml * GH-457: Updated command_processor.rs with new clippy requirements Co-authored-by: FinsaasGH <Odinallfather123> Co-authored-by: FinsaasGH <verumeritde@protonmail.com> Co-authored-by: FinsaasGH <finsaasgh@protonmail.com> * GH-418: Updated Copyright tag to reflect changes requested. Updated license with correct syntax. * GH-414: Change default mnemonic phrase to 12 (#59) * GH-414: Updated generate wallets to use 12 word mnemonic phrase as default * Updated command processor with new clippy changes Co-authored-by: FinsaasGH <Odinallfather123> Co-authored-by: dnwiebe <dnwiebe@gmail.com> * GH-418: Updated daemon_and_node_modes_version_call to 2021/12/31 Co-authored-by: FinsaasGH <Odinallfather123> Co-authored-by: FinsaasGH <verumeritde@protonmail.com> Co-authored-by: FinsaasGH <finsaasgh@protonmail.com> Co-authored-by: dnwiebe <dnwiebe@gmail.com> * GH-495: Update Rust from 2018 to 2021 (#6) * GH-473: blocked on multinode; but standard repo working; new system of descriptor wtiting roughly ready * GH-473: schema with $ and @ done but wouldn't interact well with shells; so before the new schema with url; also Blockchains as standalone structs were originated * GH-473: url syntax established; node unit tests all passing * GH-473: also multinode ready; commit before restructuring blockchaininterface into full chain records * GH-473: blockchains standardized now with their own structs for each * GH-473: clean-up * GH-473: formatting * GH-473: platform specific test code - separated now * GH-473: trying to solve platform dependant data dir in test * GH-473: fixing path for macOs in a test * GH-473: import issue in test * GH-473: data dir test modified to bypass unimportant stuff * GH-473: fixes in imports in multinode tests * GH-473: multinode chain id corrected in a few tests * GH-473: fixed one place where default of chain id in multinode tests was wrong; still a bad solution * GH-473: referring chains by num IDs standardized in multinode tests now, also veryfi_bill_payment should work well * GH-473: the code is more a standardized API for working with BlockchainRecords; also help text changed * GH-473: final arrangement of some help and error messages * GH-473: after Steve's review; but just half addressed * GH-473: before sharp knifing rooted segments out - those which don't use chain_id or just Chain * GH-473: dead-point; I refuse to go on. Let's try to restore the old design partly * GH-473: URI like syntax is in; Neighborhood fixed but tests in other files are failing * GH-473: working product * GH-473: formatting * GH-473: auto review * GH-473: formatting * GH-473: fix in imports for multinode tests * GH-473: checking multinode tests in a pre-run and cleaning the rest of conflicts in imports * GH-473: formatting * GH-473: slashes exchange semicolons * GH-473: messages inconsistent with tests - fixes in multinode * GH-473: now dev chain again fills the void in ETH id system at position 2 * GH-473: formatting * GH-488: interim commit in deploying new chain records; I stopped at mumbai chain_id too big, now a save point for changing chain id into u64 type * GH-488: chains strongly asserted; next I'm going to remove Rinkeby as decided * Rinkeby is out * GH-488: clearing a comment * GH-473: pure chain enum replaces num IDs; simplification of chain wise constants * GH-473: interim commit; removing extra features in web3 for masq_lib * GH-473: raw_transaction made working again, perhaps right * GH-473: formatting * GH-473: I forgot about fixes in multinode * GH-473: formatting * GH-473: two more tests for plygon chains; poly-mainnet syntax into more precise polygon-mainnet; help text * GH-473: formatting * GH-473: I left some defects over me * GH-473: first part of the second review addressed * GH-473: base64 url-safe-no-pad is configured now * GH-473: reaction to a new version of Rust * GH-473: simplification; I've reused code from other place for NodeReference * GH-495: Updated Rust version from 2018 to 2021 * GH-473: hardening chain names * GH-414: Change default mnemonic phrase to 12 (#59) * GH-414: Updated generate wallets to use 12 word mnemonic phrase as default * Updated command processor with new clippy changes Co-authored-by: FinsaasGH <Odinallfather123> Co-authored-by: dnwiebe <dnwiebe@gmail.com> * GH-473: refactoring tests of signing transactions * GH-418: Update copyright tags (#67) * GH-457 (#1) * GH-457: Initial cleanup of dead parameter processing. node_configurator_standard.rs and mod.rs only * GH-457: Pairing review with Dan - added initialize_database and allied tests back in * GH-457: Pairing review with Dan - added initialize_database and allied tests back in * GH-457: Pairing review with Dan - added initialize_database and allied tests back in * Delete test.txt * GH-457: Pulled commits from master, removed check_past_initialization and tests, removed TODO regarding request_existing_db_password. Removing it starts a chain of events resulting in node_configurator no longer working. * GH-457: Removed unused import. * GH-457: Removed request_existing_db_password and associated code, refactored get_db_password to pull from persistent config, removed associated tests * GH-457: Restored 2 removed tests * GH-457: Removal of streams and conflicted code. * GH-457: Updated tests and calls to run_modes_factories.rs * GH-457: removed unnecessary validators * Update and rename ci-matrix.yml to ci-ubuntu-latest.yml * Update ci-ubuntu-latest.yml * Create ci-windows-latest.yml * Create ci-macOS-latest.yml * Delete ci-windows-latest.yml * Delete ci-macOS-latest.yml * Update and rename ci-ubuntu-latest.yml to ci-matrix.yml * GH-457: Updated command_processor.rs with new clippy requirements Co-authored-by: FinsaasGH <Odinallfather123> Co-authored-by: FinsaasGH <verumeritde@protonmail.com> Co-authored-by: FinsaasGH <finsaasgh@protonmail.com> * GH-418: Updated copyright tag in 230 files & updated authors * GH-418: Updated copyright tag in 5 more files * GH-418: Updated Copyright tag to reflect changes requested. Updated license with correct syntax. * GH-418: Updated daemon_and_node_modes_version_call to 2021/12/31 Co-authored-by: FinsaasGH <verumeritde@protonmail.com> Co-authored-by: FinsaasGH <finsaasgh@protonmail.com> Co-authored-by: FinsaasGH <Odinallfather123> Co-authored-by: dnwiebe <dnwiebe@gmail.com> * GH-473: fixes reacting to testers' comments * GH-473: formatting * GH-473: late fixes * GH-473: mac specific test, detail * GH-473: finalizing * GH-473: mac specific stuff, one test * GH-473: cargo lock update (not manual) * GH-473: hardening namespace * GH-473: late fix * GH-500: Accept the proposal of enhanced logging and safer sending http requests to the blockchain service (#65) * More instrumentation for payables, and a bit of renaming * formatting * MoreInstrumentation * MoreInstrumentation: making scanning parameters more sober * MoreInstrumentation - arrangement of logs in Accountant; FailedQuery now materialized by revealing a lower level cause; removed logs of low effect from Neighborhood * MoreInstrumentation - grammatical issues with an if statement * MoreInstrumentation: the http connection should appear just one a time now * MoreInstrumentation: formatting * MoreInstrumentation: new Rust fix, I forgot about this recent event * MoreInstrumentation: trying to appease a multinode test because payment curves were changed * MoreInstrumentation: multinode test temporarily disabled because it requires exact balances for assertions and the numbers have changed because of different payment curves * GH-500: correction of needless stuff from the experiments with analyzing 'QueryFailed' * GH-500: answering a review * GH-500: forgot an unused umport * GH-500: details in comments Co-authored-by: Dan Wiebe <dnwiebe@gmail.com> * GH-473: late simplification of BlockchainRecord fileds and answering the second review * GH-473: removed redundant fieleds from BlockchainRecords, more of simplification; extra data dir for chain families is gone * GH-473: I accidentaly excluded this from the previous commit...so catching up * GH-473: fixing an intehration test about diff chain in db and cml * GH-473: chain values in masq tests were old wise * GH-473: formatting Co-authored-by: Bert <65427484+bertllll@users.noreply.github.com> Co-authored-by: dnwiebe <dnwiebe@gmail.com> Co-authored-by: FinsaasGH <verumeritde@protonmail.com> Co-authored-by: FinsaasGH <finsaasgh@protonmail.com> Co-authored-by: KauriHero <55721017+kauri-hero@users.noreply.github.com> * GH-525: Updated rust to 1.57.0 and modified clippy related changes * Update get_packet.rs * Update map_packet.rs Co-authored-by: FinsaasGH <verumeritde@protonmail.com> Co-authored-by: FinsaasGH <finsaasgh@protonmail.com> Co-authored-by: FinsaasGH <Odinallfather123> Co-authored-by: dnwiebe <dnwiebe@gmail.com> Co-authored-by: Bert <65427484+bertllll@users.noreply.github.com> Co-authored-by: KauriHero <55721017+kauri-hero@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.