fix: 🐛 play() after set_frame() resets the animation #135
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
This PR addresses an issue reported in dotlottie-web where calling
play
afterset_frame
fails to start the animation from the specified frame. Instead, the animation begins from the initial frame, disregarding the frame set by the user.The underlying problem is within the
play
method, which incorrectly assumes that if the playback state isStopped
, it should always start from the initial frame, ignoring the current frame. This behavior is only appropriate if the animation has completed its cycle and then stopped.Changes:
play
method to initiate from the initial frame only if the animation has completed, but not when it is merely stopped.play
method to ensure:Related Issue: dotlottie-web issue #174