-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
fix(linux): fix issues with rendering and touchscreens when displays are scaled #4607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(linux): fix issues with rendering and touchscreens when displays are scaled #4607
Conversation
9b32ab7 to
aa13dc4
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4607 +/- ##
==========================================
- Coverage 15.51% 15.43% -0.08%
==========================================
Files 94 94
Lines 19025 19058 +33
Branches 8769 8775 +6
==========================================
- Hits 2951 2941 -10
+ Misses 14946 14334 -612
- Partials 1128 1783 +655
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Tested kms, works properly again with 2x scaling. wlr however also doesn't work on scaled monitors now, only showing black screen and sunshine going in an endless loop of restarting the encoder. Scaled wlr worked fine on cf7b0dc. |
Bundle ReportBundle size has no change ✅ |
|
Just posted a new commit that should fix compatibility with other capture methods. If you notice anything else @Dregu could you please attach Sunshine logs? Thank you in advance! |
|
This change from the previous pr is actually the issue and that resolution then gets used by wlgrab https://github.com/LizardByte/Sunshine/pull/4594/changes#diff-e26c5ae6fcf2fcb3435e6cafe5f2e3ce373dada1e442ec74dd945ac0fdfa2621R147-R148 |
|
Thanks for noticing that! I already fixed it. Now viewport.width and height are untouched, which should make things right. |
Indeed, all screens seem to be streaming again in wlr and kms. |
85038f3 to
cc53a1c
Compare
|
|
Hi @ReenigneArcher @juliosanz I'm using the new XDG Screen Capture btw. |




Description
Implements better, more complete support for logical sizes following up PR #4594, fixing issue #4599 and enhancing support for touchscreens when using multiple scaled monitors in Wayland (#2166).
Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage