Skip to content

Conversation

@juliosanz
Copy link
Contributor

Description

Enforces use of zxdg_output_v1 to get logical dimensions of screen instead of physical when using KMS with Wayland, fixing touch screen support when scale of touch screen is 100% and scale of other devices were different than 100%.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@juliosanz juliosanz changed the title added support for logical screen size with zxdg_output_v1 fix(linux): added support for logical screen size with zxdg_output_v1 Jan 17, 2026
@sonarqubecloud
Copy link

@codecov
Copy link

codecov bot commented Jan 18, 2026

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 15.46%. Comparing base (b0bf510) to head (678ba0a).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/platform/linux/kmsgrab.cpp 0.00% 2 Missing ⚠️
src/platform/linux/wayland.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4594      +/-   ##
==========================================
+ Coverage   13.72%   15.46%   +1.73%     
==========================================
  Files          61       94      +33     
  Lines       11852    19028    +7176     
  Branches     5174     8771    +3597     
==========================================
+ Hits         1627     2942    +1315     
- Misses       9533    12728    +3195     
- Partials      692     3358    +2666     
Flag Coverage Δ
Archlinux 11.54% <0.00%> (?)
FreeBSD-14.3-aarch64 ?
FreeBSD-14.3-amd64 13.81% <0.00%> (?)
Homebrew-ubuntu-22.04 13.82% <0.00%> (?)
Linux-AppImage 11.85% <0.00%> (?)
Windows-AMD64 13.47% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/platform/linux/kmsgrab.cpp 3.66% <0.00%> (ø)
src/platform/linux/wayland.cpp 3.00% <0.00%> (+3.00%) ⬆️

... and 85 files with indirect coverage changes

@ReenigneArcher ReenigneArcher merged commit c313851 into LizardByte:master Jan 18, 2026
52 of 53 checks passed
@codecov
Copy link

codecov bot commented Jan 18, 2026

Bundle Report

Changes will increase total bundle size by 21.17kB (1.11%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sunshine-esm 968.59kB 21.17kB (2.23%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: sunshine-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/_plugin-*.js 21.33kB 344.81kB 6.59% ⚠️
assets/config-*.js -23 bytes 60.83kB -0.04%
assets/apps-*.js -23 bytes 4.02kB -0.57%
assets/index-*.js -23 bytes 2.91kB -0.78%
assets/troubleshooting-*.js -23 bytes 2.42kB -0.94%
assets/pin-*.js -23 bytes 860 bytes -2.6%
assets/welcome-*.js -23 bytes 661 bytes -3.36%
assets/password-*.js -23 bytes 638 bytes -3.48%

@rubin55
Copy link

rubin55 commented Jan 18, 2026

@juliosanz I think this is the reason for me suddenly seeing only a quarter of my screen; I run the git version of sunshine and with this commit in, I only see the left-upper quarter of the screen (I'm using Arch Linux + Wayland on both client and server, Moonlight current-git to connect)

Update: confirmed, went back to commit b0bf510 and scaling works normally again - I created #4599 to track it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Touch input is wrong on multi-monitor configurations on Linux

3 participants