CubismMotionSyncCriEngine が予期せず Dispose される事があるのを修正 #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
複数の Live2D を同時にインスタンス化する際に、一部の CubismMotionSyncCriProcessor の enable を落とした状態でインスタンスを作り、enable が true になることなく Destroy された場合に問題が発生した。 上記状況では、CubismMotionSyncCriProcessor の Start が呼ばれる回数と Destroy が呼ばれる回数の対称性が崩れる。 それにより CubismMotionSyncCriEngine.ReferenceCount に不整合が生じ、まだ有効な CubismMotionSyncCriProcessor があるのに CubismMotionSyncEngine_CRI.DisposeEngine が呼ばれてしまい、リップシンクが停止してしまう
There was a problem hiding this comment.
@ppcuni
Thank you for pull request and investigation!
As preparation to incorporate this fix, we are suggestion one modification to align with our coding conventions. Once that change is complete, we plan to commit the CHANGELOG to your branch to include it.
Assets/Live2D/CubismMotionSyncPlugin/Framework/Processor/CRI/CubismMotionSyncCriProcessor.cs
Outdated
Show resolved
Hide resolved
…ubismMotionSyncCriProcessor.cs Co-authored-by: Sohma Tanaka <81139027+tanakaso-at-live2d-com@users.noreply.github.com>
|
@ppcuni |
tanakaso-at-live2d-com
approved these changes
Jul 5, 2024
wada-at-live2d-com
approved these changes
Jul 11, 2024
This was referenced Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
複数の Live2D を同時にインスタンス化する際に、一部の CubismMotionSyncCriProcessor の enable を落とした状態でインスタンスを作り、enable が true になることなく Destroy された場合に問題が発生した。
(CubismMotionSyncCriProcessor.MotionSyncAudioInput はボイス再生時まで代入したくないのでインスタンス化直後は無効化するようにしていた。その状態でセリフを喋らない Live2D を登場させて退場させるシーンを作ったら再現した)
上記状況では、CubismMotionSyncCriProcessor の Start が呼ばれる回数と Destroy が呼ばれる回数の対称性が崩れる。
それにより CubismMotionSyncCriEngine.ReferenceCount に不整合が生じ、まだ有効な CubismMotionSyncCriProcessor があるのに CubismMotionSyncEngine_CRI.DisposeEngine が呼ばれてしまい、リップシンクが停止してしまう。