Halscope always 16 channels, and add user configurable samples by grandixximo · Pull Request #3722 · LinuxCNC/linuxcnc

grandixximo · 2026-01-20T15:07:40Z

The default memory has been increased, and user can set custom memory and restart to get less or more.

During the work on the jerk control have been using the scope a lot, this makes it a better tool for debugging.

grandixximo · 2026-01-21T04:11:07Z

I think I pulled at the wrong time, I will try to fix it

- Add GUI control for sample count in acquire dialog with config file persistence (SAMPLES command read before scope_rt loads) - Always enable all 16 channels - remove confusing record length radio buttons that forced tradeoff between channels and samples - Initialize sample_len and rec_len in init_horiz() so sampling works immediately without opening acquire dialog - Add bounds checking for num_samples (min 1000, max 1000000) - Increase default window size to 1050x550 for better channel display - Show restart message when sample count changed (requires reload)

grandixximo · 2026-01-21T09:44:17Z

Is retro compatibility important?
Like if switch back to 2.9, you want to open the 2.10 new halscope files, should that be supported?
I would need to add my new settings in a comment as the .halscope file, is that acceptable? or screw retro-compatibility?

2.10 can open 2.9 settings, but 2.9 will not understand 2.10 settings

…onfigs

grandixximo · 2026-01-21T09:50:36Z

I implemented full bidirectional compatibility, so whomever switches branches won't be bothered by the changes

hansu · 2026-01-21T09:52:11Z

What happens if 2.9 halscope reads a 2.10 halscope file? If it still reads all "old" parameters except the new ones it would be no problem. But I haven't looked into it if it may fail to read the file at all?

grandixximo · 2026-01-21T10:11:28Z

What happens if 2.9 halscope reads a 2.10 halscope file? If it still reads all "old" parameters except the new ones it would be no problem. But I haven't looked into it if it may fail to read the file at all?

Previous commit 2.9 would just not open the new files, probably cause I had the new config in the header, but I think it makes more sense to have it in the header as a comment which 2.10 can parse, and 2.9 ignores, already pushed the commit to fix this...

andypugh · 2026-01-21T12:29:07Z

I am not sure that Halscope usefully opens files?
You can save-out the data files but AFAIK you can't load one in to analyse it.
#966
While you are at it.... :-)

hansu · 2026-01-21T12:38:11Z

I am not sure that Halscope usefully opens files?

It can open configuration files...

grandixximo · 2026-01-21T12:59:28Z

On it

grandixximo · 2026-01-21T14:40:27Z

Simple job for my stochastic parrot 🤭
I tested, everything seems in order, you can open a log and view it, even if you don't have the pins of the original logger, phantom log pins will be created for you, and forced to be enabled, the CVS also contains the configuration, so everything will look like what it did in the original log scaling and position, but it can be changed zoomed etc, rolling will clear the loaded log.

andypugh · 2026-01-22T22:22:58Z

Thanks for this.

snowgoer540 · 2026-02-01T20:21:50Z

This seems in a few ways a step in the right direction for modern hardware, but it seems there are also a few issues...

On my system, no matter what I do, I cant get it to increase the number of samples. It is locked at "Current: 32000 samples (2000 per channel)". I've tried everything I can think of, it appends the autosave.halscope file correctly, but upon the next launch of halscope, the only thing that has changed is the "Samples (16 channels):" field. It shows the value I saved, but it remains at "Current: 32000 samples (2000 per channel)".
I am a bit unsure why you did away with the chooser for the number of channels (and subsequently the samples per channel). In the new version the number of Samples I choose is divided among all 16 channels, always, whether I use them or not. So if I want 32000 samples on 1 channel. I have to make my Samples 512,000 (32000 * 16). Is that the intent?
When I launch halscope. I get these errors in the terminal window:

halscope: command not implemented: '# SAMPLES 32000'
halscope: config file 'autosave.halscope' caused 1 warnings

I think (pretty sure) that is because in the function "read_config_file" in scope.c, there is no way to handle comments. So it tries incorrectly to execute the command # SAMPLES 32000, when that line should be ignored.

grandixximo · 2026-02-01T21:27:14Z

This seems in a few ways a step in the right direction for modern hardware, but it seems there are also a few issues...
1. On my system, no matter what I do, I cant get it to increase the number of samples.  It is locked at "Current: 32000 samples (2000 per channel)".  I've tried everything I can think of, it appends the autosave.halscope file correctly, but upon the next launch of halscope, the only thing that has changed is the "Samples (16 channels):" field.  It shows the value I saved, but it remains at "Current: 32000 samples (2000 per channel)".

2. I am a bit unsure why you did away with the chooser for the number of channels (and subsequently the samples per channel).  In the new version the number of Samples I choose is divided among all 16 channels, always, whether I use them or not.  So if I want 32000 samples on 1 channel. I have to make my Samples 512,000 (32000 * 16).  Is that the intent?

3. When I launch halscope. I get these errors in the terminal window:
halscope: command not implemented: '# SAMPLES 32000' halscope: config file 'autosave.halscope' caused 1 warnings

I think (pretty sure) that is because in the function "read_config_file" in scope.c, there is no way to handle comments. So it tries incorrectly to execute the command # SAMPLES 32000, when that line should be ignored.

Need restart linuxcnc to get bigger buffer.
I can ask user to input per channel memory, and then multiply internally by 16, I did away with choose how many channels, because the messages when you needed more channels were annoying.
For retro compatibility the new sample count is in a comment, but the counter effect is that comments are not really ignored anymore, can you share the halscope file? did you write comments manually?

snowgoer540 · 2026-02-01T21:39:47Z

Need restart linuxcnc to get bigger buffer.

Wow, I feel a bit silly, but that was not apparent to me. I took the message at face value: "The new sample count (512000) will take effect the next time halscope is started." It seems it should be modified to say that linuxcnc needs to be restarted entirely.

I do wonder why we need to restart though. It seems like it's memory allocation, but is there a problem with just setting the necessary memory to a max? In modern PCs this can only be a few Mb, right?

I can ask user to input per channel memory, and then multiply internally by 16, I did away with choose how many channels, because the messages when you needed more channels were annoying.
It was just a bit counter intuitive. I think things might be better if restarting linuxcnc was not necessary.

For retro compatibility the new sample count is in a comment, but the counter effect is that comments are not really ignored anymore, can you share the halscope file? did you write comments manually?

the contents of the file are just:

# SAMPLES 512000
MAXCHAN 16
THREAD servo-thread
HMULT 1
HZOOM 1
HPOS 5.000000e-01
TMODE 0
RMODE 0

I did make a quick modification to read_config_file to ignore lines with comments, and it made the aforementioned errors go away. It's trying to pass the commented line to parse_command() and it does not like it.

snowgoer540 · 2026-02-05T01:28:12Z

I created this pull request that addresses the above:

#3788

grandixximo mentioned this pull request Jan 20, 2026

scope to 32k #3705

Closed

Luca Toniolo added 2 commits January 21, 2026 13:10

the scope gets double the samples, and starts with full Pos not half

9c21e1b

grandixximo force-pushed the master branch from 79ec5e6 to c2a4427 Compare January 21, 2026 05:11

rmu75 added enhancement hal component labels Jan 21, 2026

Parse new configs from a comment, to allow 2.9 halscope to open new c…

13755b9

…onfigs

halscope open logs

402a96d

grandixximo mentioned this pull request Jan 21, 2026

Halscope - Can save data files but not open them #966

Closed

andypugh merged commit 891b22b into LinuxCNC:master Jan 22, 2026
14 checks passed

Conversation

grandixximo commented Jan 20, 2026

Uh oh!

grandixximo commented Jan 21, 2026

Uh oh!

grandixximo commented Jan 21, 2026

Uh oh!

grandixximo commented Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hansu commented Jan 21, 2026

Uh oh!

grandixximo commented Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

andypugh commented Jan 21, 2026

Uh oh!

hansu commented Jan 21, 2026

Uh oh!

grandixximo commented Jan 21, 2026

Uh oh!

grandixximo commented Jan 21, 2026

Uh oh!

andypugh commented Jan 22, 2026

Uh oh!

Uh oh!

snowgoer540 commented Feb 1, 2026

Uh oh!

grandixximo commented Feb 1, 2026

Uh oh!

snowgoer540 commented Feb 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

snowgoer540 commented Feb 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

grandixximo commented Jan 21, 2026 •

edited

Loading

grandixximo commented Jan 21, 2026 •

edited

Loading

snowgoer540 commented Feb 1, 2026 •

edited

Loading