Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #20: Add parameter for github access token for an increased rate limit #21

Merged
merged 4 commits into from
Oct 14, 2023
Merged

Fixes #20: Add parameter for github access token for an increased rate limit #21

merged 4 commits into from
Oct 14, 2023

Conversation

Raamyy
Copy link
Contributor

@Raamyy Raamyy commented Sep 30, 2023 •
edited by Link-
Loading

Fixes #20

Add parameter for github access token for an increased rate limit

@Raamyy Raamyy changed the title Fixes #2: Add parameter for github access token for an increased rate limit Fixes #20: Add parameter for github access token for an increased rate limit Sep 30, 2023
Link-
Link- reviewed Oct 11, 2023
View reviewed changes
src/cli.js Outdated Show resolved Hide resolved
Link-
Link- requested changes Oct 11, 2023
View reviewed changes
Copy link
Owner

@Link- Link- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this addition, thank you 🙏 let's just make it more secure

Link-
Link- reviewed Oct 14, 2023
View reviewed changes
src/cli.js Outdated Show resolved Hide resolved
@Raamyy
Copy link
Contributor Author

Raamyy commented Oct 14, 2023

@Link- I have resolved it, and I added dotenv package so it can be read from .env file also. However this resulted in making bunch of changes in the package.lock file. I think is because I'm using a bit older version of npm. So is it okay having it with these changes or should I do something specific 🤔

Link-
Link- approved these changes Oct 14, 2023
View reviewed changes
Copy link
Owner

@Link- Link- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's 🚢 it

@Link- Link- merged commit 8e37de9 into Link-:master Oct 14, 2023
@Link- Link- added the enhancement New feature or request label Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Link- Link- Link- approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add parameter for github access token
2 participants
@Raamyy @Link-