Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add parameter for github access token #20

Closed
Raamyy opened this issue Sep 30, 2023 · 2 comments · Fixed by #21
Closed

Add parameter for github access token #20

Raamyy opened this issue Sep 30, 2023 · 2 comments · Fixed by #21
Assignees
@Raamyy

Comments

@Raamyy
Copy link
Contributor

Raamyy commented Sep 30, 2023

Unauthenticated requests without github access tokens are rate limited to 60 requests per hour, and the application may send many requests in one run. A parameter should be added to allow users to add their access token to the requests.

-t, --token <github access token> (optional)
  A github access token to be used in sending requests. generate one from here (https://github.com/settings/tokens?type=beta)

# usage example
$ starred_search -u 'link-' -f 'es6' -t github_pat_*****
@Raamyy
Copy link
Contributor Author

Raamyy commented Sep 30, 2023

On it ✔️

Raamyy added a commit to Raamyy/starred_search that referenced this issue Sep 30, 2023
@Raamyy
fixes Link-#20: add parameter for github access token for an increase…
0c0f15b 
…d rate limit
@Raamyy
Copy link
Contributor Author

Raamyy commented Sep 30, 2023

@Link- It would be great if you add hacktoberfest topic to the repo 😁

Raamyy added a commit to Raamyy/starred_search that referenced this issue Oct 14, 2023
@Raamyy
fixes Link-#20: revert reading gh token from args and read from env i…
8b9e897 
…nstead
Raamyy added a commit to Raamyy/starred_search that referenced this issue Oct 14, 2023
@Raamyy
fixes Link-#20: revert reading gh token from args and read from env i…
d250cc5 
…nstead
@Link- Link- mentioned this issue Oct 14, 2023
Merged
@Link- Link- closed this as completed in #21 Oct 14, 2023
Link- added a commit that referenced this issue Oct 14, 2023
@Raamyy @Link-
Fixes #20: Add parameter for github access token for an increased rat…
8e37de9 
…e limit (#21)

* fixes #20: add parameter for github access token for an increased rate limit

* fixes #20: revert reading gh token from args and read from env instead

* Remove dotenv dependency

* Cleanup README

---------

Co-authored-by: Bassem Dghaidi <568794+Link-@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Raamyy Raamyy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #20: Add parameter for github access token for an increased rate limit Raamyy/starred_search
1 participant
@Raamyy