Fix bug in notebook task (kubeflow#728)

* The script to run a notebook is missing a trailing slash to indicate a continued command. * Related to GoogleCloudPlatform/kubeflow-distribution#78
Linchin · Jul 11, 2020 · abce371 · abce371
1 parent b20d0eb
commit abce371
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/acm-repos/kf-ci-v1/namespaces/auto-deploy/tekton.dev_v1alpha1_task_nb-tests.yaml b/acm-repos/kf-ci-v1/namespaces/auto-deploy/tekton.dev_v1alpha1_task_nb-tests.yaml
@@ -72,7 +72,7 @@ spec:
         --notebook_path=/src/notebook-repo/$(inputs.params.notebook-path) \
         --test-target-name=$(inputs.params.test-target-name) \
         --artifacts-gcs=$(inputs.params.notebook-output) \
-        --image_file=$(inputs.params.artifacts-gcs)/image.yaml
+        --image_file=$(inputs.params.artifacts-gcs)/image.yaml \
         --namespace=$(inputs.params.nb-namespace)
       echo test finished
     workingDir: /srcCache/kubeflow/testing/py/kubeflow/testing/notebook_tests

diff --git a/acm-repos/kf-ci-v1/namespaces/kf-ci/tekton.dev_v1alpha1_task_nb-tests.yaml b/acm-repos/kf-ci-v1/namespaces/kf-ci/tekton.dev_v1alpha1_task_nb-tests.yaml
@@ -72,7 +72,7 @@ spec:
         --notebook_path=/src/notebook-repo/$(inputs.params.notebook-path) \
         --test-target-name=$(inputs.params.test-target-name) \
         --artifacts-gcs=$(inputs.params.notebook-output) \
-        --image_file=$(inputs.params.artifacts-gcs)/image.yaml
+        --image_file=$(inputs.params.artifacts-gcs)/image.yaml \
         --namespace=$(inputs.params.nb-namespace)
       echo test finished
     workingDir: /srcCache/kubeflow/testing/py/kubeflow/testing/notebook_tests

diff --git a/tekton/templates/tasks/notebook-test-task.yaml b/tekton/templates/tasks/notebook-test-task.yaml
@@ -76,7 +76,7 @@ spec:
         --notebook_path=/src/notebook-repo/$(inputs.params.notebook-path) \
         --test-target-name=$(inputs.params.test-target-name) \
         --artifacts-gcs=$(inputs.params.notebook-output) \
-        --image_file=$(inputs.params.artifacts-gcs)/image.yaml
+        --image_file=$(inputs.params.artifacts-gcs)/image.yaml \
         --namespace=$(inputs.params.nb-namespace)
       echo test finished
     workingDir: /srcCache/kubeflow/testing/py/kubeflow/testing/notebook_tests