Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix small mistakes in docs #1984

Merged
merged 6 commits into from
Aug 7, 2023
Merged

Fix small mistakes in docs #1984

merged 6 commits into from
Aug 7, 2023

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Aug 7, 2023

What does this PR do?

Fixes #1962
Fixes many smaller mistakes in docs that does not render correct.

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--1984.org.readthedocs.build/en/1984/

@SkafteNicki SkafteNicki added the documentation Improvements or additions to documentation label Aug 7, 2023
@SkafteNicki SkafteNicki added this to the v1.1.0 milestone Aug 7, 2023
@Borda Borda enabled auto-merge (squash) August 7, 2023 12:48
@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Merging #1984 (04a4c5e) into master (4259943) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #1984   +/-   ##
======================================
  Coverage      86%     86%           
======================================
  Files         266     266           
  Lines       15185   15185           
======================================
  Hits        13131   13131           
  Misses       2054    2054           

@mergify mergify bot added the ready label Aug 7, 2023
Copy link
Contributor

@lantiga lantiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@Borda Borda merged commit b22ca97 into master Aug 7, 2023
61 checks passed
@Borda Borda deleted the docs/smaller_mistakes branch August 7, 2023 16:56
Borda pushed a commit that referenced this pull request Aug 8, 2023
(cherry picked from commit b22ca97)
Borda pushed a commit that referenced this pull request Aug 8, 2023
(cherry picked from commit b22ca97)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fixes needed for docs
3 participants