Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes needed for docs #1962

Closed
65 of 67 tasks
lantiga opened this issue Aug 1, 2023 · 10 comments · Fixed by #1984
Closed
65 of 67 tasks

Fixes needed for docs #1962

lantiga opened this issue Aug 1, 2023 · 10 comments · Fixed by #1984
Labels
documentation Improvements or additions to documentation Priority Critical task/issue
Milestone

Comments

@lantiga
Copy link
Contributor

lantiga commented Aug 1, 2023

📚 Documentation

Broken links to assets:

samples
@lantiga lantiga added the documentation Improvements or additions to documentation label Aug 1, 2023
@github-actions
Copy link

github-actions bot commented Aug 1, 2023

Hi! thanks for your contribution!, great first issue!

@Borda Borda added the Priority Critical task/issue label Aug 1, 2023
@Borda Borda added this to the v1.0.x milestone Aug 1, 2023
@Borda
Copy link
Member

Borda commented Aug 1, 2023

broken links in https://torchmetrics.readthedocs.io/en/latest/pages/all-metrics.html are related to #1930 need to find way to update gallery :( or eventually, work on some redirect...

@Borda
Copy link
Member

Borda commented Aug 1, 2023

  • Plots (eg for mean, but it's also for all the others) are preceded by a (,,,) string that is unclear

@SkafteNicki mind checking this one? 🐰

@Borda
Copy link
Member

Borda commented Aug 1, 2023

Broken links to assets:

this seems to be just PR rendering issue with latex as on the latest as well as old 0.11.0 are fine

@Borda
Copy link
Member

Borda commented Aug 1, 2023

  • AUROC docstring has formatting issues (way too many spaces between square brackets etc (this is also true for a number of other pages, like Average Precision):

this seems to be an annotation issue as some from the typing package are missing, so could be resolved in #1916

@lantiga
Copy link
Contributor Author

lantiga commented Aug 7, 2023

@Borda @SkafteNicki checked all links, looks good!

Nit: can you check the formula for the Minkowski distance? It breaks up for me https://lightning.ai/docs/torchmetrics/stable/regression/minkowski_distance.html

image

@SkafteNicki
Copy link
Member

@Borda @SkafteNicki checked all links, looks good!

Nit: can you check the formula for the Minkowski distance? It breaks up for me https://lightning.ai/docs/torchmetrics/stable/regression/minkowski_distance.html

image

Yes let me figure out what is wrong with that. @lantiga could you also be more specific about the missing line break regarding the pip install mentioned above, because it looks fine on my end.

@lantiga
Copy link
Contributor Author

lantiga commented Aug 7, 2023

Thank you @SkafteNicki , this is what I get on my browser

image

@lantiga
Copy link
Contributor Author

lantiga commented Aug 7, 2023

@SkafteNicki looks like it's a Safari thing

@lantiga
Copy link
Contributor Author

lantiga commented Aug 7, 2023

looks good on Chrome, probably not worth getting too crazy about it
let's only fix the Minkowski formula and we're good @Borda

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation Priority Critical task/issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants