Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert classification wrapper to metrics #1963

Merged
merged 11 commits into from
Aug 3, 2023

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Aug 1, 2023

What does this PR do?

Fixes #1953
Make sure that even the task wrapper classes are subclasses of Metric (to make sure it works with lightning CLI, see issue).

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--1963.org.readthedocs.build/en/1963/

@SkafteNicki SkafteNicki added bug / fix Something isn't working enhancement New feature or request labels Aug 1, 2023
@SkafteNicki SkafteNicki added this to the v1.1.0 milestone Aug 1, 2023
@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #1963 (d0fec3f) into master (ea17ffb) will decrease coverage by 33%.
The diff coverage is 79%.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #1963     +/-   ##
========================================
- Coverage      83%     51%    -33%     
========================================
  Files         265     266      +1     
  Lines       15143   15177     +34     
========================================
- Hits        12595    7684   -4911     
- Misses       2548    7493   +4945     

@Borda Borda enabled auto-merge (squash) August 3, 2023 07:34
@mergify mergify bot added the ready label Aug 3, 2023
@Borda Borda merged commit f6b5890 into master Aug 3, 2023
61 checks passed
@Borda Borda deleted the convert_classification_wrapper_to_metrics branch August 3, 2023 13:49
Borda pushed a commit that referenced this pull request Aug 3, 2023
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

(cherry picked from commit f6b5890)
Borda pushed a commit that referenced this pull request Aug 3, 2023
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

(cherry picked from commit f6b5890)
@SkafteNicki SkafteNicki mentioned this pull request Aug 5, 2023
67 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working enhancement New feature or request ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Import path torchmetrics.Precision does not correspond to a subclass of <class 'torchmetrics.metric.Metric'>
3 participants