-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix support for dataclasses with ClassVar/InitVar in apply_to_collection
#9702
Fix support for dataclasses with ClassVar/InitVar in apply_to_collection
#9702
Conversation
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## master #9702 +/- ##
=======================================
- Coverage 93% 89% -4%
=======================================
Files 181 181
Lines 16370 16381 +11
=======================================
- Hits 15144 14526 -618
- Misses 1226 1855 +629 |
apply_to_collection
Dear @a-gardner1, Would you mind resolving the conflicts ? Best, |
Sure. Just a heads-up, though, that I'm unlikely to have time to get back to this before November. |
…s-initvar Conflicts resolved: CHANGELOG.md pytorch_lightning/utilities/apply_func.py tests/utilities/test_apply_func.py
Approved the CI to run - you can ping me on Slack if you need it again. It's no longer necessary after the first contribution. |
I cannot reproduce the failed test. To the best of my knowledge, it does not use anything that this PR has modified. Local environment vs failed CI environment:
|
pytorch_lightning/trainer/connectors/logger_connector/result.py
Outdated
Show resolved
Hide resolved
…s-initvar Conflicts resolved: CHANGELOG.md
…tion` (#9702) Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com> Co-authored-by: Carlos Mocholi <carlossmocholi@gmail.com>
…tion` (#9702) Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com> Co-authored-by: Carlos Mocholi <carlossmocholi@gmail.com>
…tion` (Lightning-AI#9702) Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com> Co-authored-by: Carlos Mocholi <carlossmocholi@gmail.com>
What does this PR do?
Adds/fixes support for ClassVar and InitVar fields in dataclasses to apply_to_collection
Fixes #9208
Does your PR introduce any breaking changes? If yes, please list them.
None
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃